Skip to content

Commit

Permalink
[main] Schema RPC to fetch table/view definition (#12375) (#12397)
Browse files Browse the repository at this point in the history
* feat: proto changes to add new rpc

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* feat: vttablet changes in queryservice to implement the new rpc

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* added test on tabletserver

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* feat: use the new schema rpc in vtgate to get updated view definition

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* remove error from getschemaresponse and change the enum name

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* updated proto files for vtadmin

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* fix e2e test

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
  • Loading branch information
vitess-bot[bot] and harshit-gangal committed Feb 21, 2023
1 parent ce9f70b commit 1f60c7b
Show file tree
Hide file tree
Showing 22 changed files with 2,065 additions and 488 deletions.
7 changes: 1 addition & 6 deletions go/mysql/schema.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,7 @@ import (
querypb "vitess.io/vitess/go/vt/proto/query"
)

// This file provides a few utility variables and methods, mostly for tests.
// The assumptions made about the types of fields and data returned
// by MySQl are validated in schema_test.go. This way all tests
// can use these variables and methods to simulate a MySQL server
// (using fakesqldb/ package for instance) and still be guaranteed correct
// data.
// This file contains the mysql queries used by different parts of the code.

const (
// BaseShowPrimary is the base query for fetching primary key info.
Expand Down
822 changes: 520 additions & 302 deletions go/vt/proto/query/query.pb.go

Large diffs are not rendered by default.

0 comments on commit 1f60c7b

Please sign in to comment.