logs: remove logging in GetDurabilityPolicy since it is overtly noisy…

… and move it to places which will only be called less frequently (#10516) (#10518) Signed-off-by: Manan Gupta <manan@planetscale.com>
vitessio · Jun 16, 2022 · 4911839 · 4911839
1 parent 9c74850
commit 4911839
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 1 deletion.
diff --git a/go/vt/vtctl/grpcvtctldserver/server.go b/go/vt/vtctl/grpcvtctldserver/server.go
@@ -476,6 +476,7 @@ func (s *VtctldServer) ChangeTabletType(ctx context.Context, req *vtctldatapb.Ch
 	if err != nil {
 		return nil, err
 	}
+	log.Infof("Getting a new durability policy for %v", durabilityName)
 	durability, err := reparentutil.GetDurabilityPolicy(durabilityName)
 	if err != nil {
 		return nil, err
@@ -1750,6 +1751,7 @@ func (s *VtctldServer) InitShardPrimaryLocked(
 	if err != nil {
 		return err
 	}
+	log.Infof("Getting a new durability policy for %v", durabilityName)
 	durability, err := reparentutil.GetDurabilityPolicy(durabilityName)
 	if err != nil {
 		return err
@@ -2324,6 +2326,7 @@ func (s *VtctldServer) ReparentTablet(ctx context.Context, req *vtctldatapb.Repa
 	if err != nil {
 		return nil, err
 	}
+	log.Infof("Getting a new durability policy for %v", durabilityName)
 	durability, err := reparentutil.GetDurabilityPolicy(durabilityName)
 	if err != nil {
 		return nil, err
@@ -3035,6 +3038,7 @@ func (s *VtctldServer) StartReplication(ctx context.Context, req *vtctldatapb.St
 	if err != nil {
 		return nil, err
 	}
+	log.Infof("Getting a new durability policy for %v", durabilityName)
 	durability, err := reparentutil.GetDurabilityPolicy(durabilityName)
 	if err != nil {
 		return nil, err
@@ -3133,6 +3137,7 @@ func (s *VtctldServer) TabletExternallyReparented(ctx context.Context, req *vtct
 	if err != nil {
 		return nil, err
 	}
+	log.Infof("Getting a new durability policy for %v", durabilityName)
 	durability, err := reparentutil.GetDurabilityPolicy(durabilityName)
 	if err != nil {
 		return nil, err

diff --git a/go/vt/vtctl/reparentutil/durability.go b/go/vt/vtctl/reparentutil/durability.go
@@ -79,7 +79,6 @@ func GetDurabilityPolicy(name string) (Durabler, error) {
 	if !found {
 		return nil, fmt.Errorf("durability policy %v not found", name)
 	}
-	log.Infof("Getting a new durability policy for %v", name)
 	return newDurabilityCreationFunc(), nil
 }
 

diff --git a/go/vt/vtctl/reparentutil/emergency_reparenter.go b/go/vt/vtctl/reparentutil/emergency_reparenter.go
@@ -167,6 +167,7 @@ func (erp *EmergencyReparenter) reparentShardLocked(ctx context.Context, ev *eve
 		return err
 	}
 
+	erp.logger.Infof("Getting a new durability policy for %v", keyspaceDurability)
 	opts.durability, err = GetDurabilityPolicy(keyspaceDurability)
 	if err != nil {
 		return err

diff --git a/go/vt/vtctl/reparentutil/planned_reparenter.go b/go/vt/vtctl/reparentutil/planned_reparenter.go
@@ -514,6 +514,7 @@ func (pr *PlannedReparenter) reparentShardLocked(
 		return err
 	}
 
+	pr.logger.Infof("Getting a new durability policy for %v", keyspaceDurability)
 	opts.durability, err = GetDurabilityPolicy(keyspaceDurability)
 	if err != nil {
 		return err

diff --git a/go/vt/vtctl/reparentutil/replication.go b/go/vt/vtctl/reparentutil/replication.go
@@ -188,6 +188,7 @@ func SetReplicationSource(ctx context.Context, ts *topo.Server, tmc tmclient.Tab
 	if err != nil {
 		return err
 	}
+	log.Infof("Getting a new durability policy for %v", durabilityName)
 	durability, err := GetDurabilityPolicy(durabilityName)
 	if err != nil {
 		return err

diff --git a/go/vt/wrangler/reparent.go b/go/vt/wrangler/reparent.go
@@ -137,6 +137,7 @@ func (wr *Wrangler) TabletExternallyReparented(ctx context.Context, newPrimaryAl
 		if err != nil {
 			return err
 		}
+		log.Infof("Getting a new durability policy for %v", durabilityName)
 		durability, err := reparentutil.GetDurabilityPolicy(durabilityName)
 		if err != nil {
 			return err