Skip to content

Commit

Permalink
fix bug: missing negation. Vitess app should not affect non-low-prior…
Browse files Browse the repository at this point in the history
…ity app requests

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
  • Loading branch information
shlomi-noach committed May 23, 2024
1 parent 9ba160d commit 8bae917
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion go/vt/vttablet/tabletserver/throttle/check.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func (check *ThrottlerCheck) checkAppMetricResult(ctx context.Context, appName s
statusCode = http.StatusTooManyRequests // 429
err = base.ErrThresholdExceeded

if !flags.LowPriority && !flags.ReadCheck && throttlerapp.VitessName.Equals(appName) {
if !flags.LowPriority && !flags.ReadCheck && !throttlerapp.VitessName.Equals(appName) {
// low priority requests will henceforth be denied
go check.throttler.nonLowPriorityAppRequestsThrottled.SetDefault("", true)
}
Expand Down

0 comments on commit 8bae917

Please sign in to comment.