Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite flagutil.OptionalFlag to use generics #11154

Open
ajm188 opened this issue Sep 1, 2022 · 6 comments
Open

Rewrite flagutil.OptionalFlag to use generics #11154

ajm188 opened this issue Sep 1, 2022 · 6 comments

Comments

@ajm188
Copy link
Contributor

ajm188 commented Sep 1, 2022

Now that we have generics, we can stop hand-writing each implementation of flagutil.OptionalFlag for each type we want, instead writing a generic OptionalFlag over any type T, providing a parsing function that has the signature func(string) (T, error)

@ajm188 ajm188 created this issue from a note in Technical debt / Cleanup (To do) Sep 1, 2022
@ajm188 ajm188 self-assigned this Sep 1, 2022
@ajm188 ajm188 removed their assignment Sep 1, 2022
@MdSahil-oss
Copy link

@ajm188 I would like to give a try to this issue.

@divaspathak
Copy link

Hello @ajm188, I would like to work on this issue. Can you please assign it to me?

@ajm188
Copy link
Contributor Author

ajm188 commented Sep 8, 2022

I believe @MdSahil-oss is working on this, unless that's changed. Please feel free to collaborate with each other in the OSS slack

@MdSahil-oss MdSahil-oss removed their assignment Oct 15, 2022
@SaarthakMaini
Copy link

@ajm188 , I would like to work on this issue if no one is working on it
If possible, could it be assigned to me?
Thank you!

@ajm188
Copy link
Contributor Author

ajm188 commented Dec 29, 2022

@ajm188 , I would like to work on this issue if no one is working on it
If possible, could it be assigned to me?
Thank you!

#11154 (comment)

@divaspathak divaspathak removed their assignment Dec 31, 2022
@gokulav137
Copy link

gokulav137 commented Oct 21, 2023

I would like to have a go at this if thats fine, @ajm188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

5 participants