Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Code Checks Etc does not fail if the ./changelog is out-of-date #14002

Closed
frouioui opened this issue Sep 15, 2023 · 0 comments · Fixed by #14003
Closed

Static Code Checks Etc does not fail if the ./changelog is out-of-date #14002

frouioui opened this issue Sep 15, 2023 · 0 comments · Fixed by #14003

Comments

@frouioui
Copy link
Member

Overview of the Issue

The ./changelog/ directory and subdirectories contain several README files that allow easy navigation of release notes on GitHub. We have a test (``) in the Static Code Checks Etc workflow that checks if the directory is always up-to-date but the test never fails (`exit 1`). We should make it fail so we don't forget to run the `releases.go` script while changing the release notes.

Reproduction Steps

Change the ./changelog directory by adding a release (i.e. ./changelog/19.0.0/19.0/release_notes.md), open a PR and the Static Code Checks Etc will still be green even though go run ./go/tools/releases/releases.go changes the changelog directory.

Binary Version

main

Operating System and Environment details

n/a

Log Fragments

No response

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant