Wait for all replicas to reparent when running ERS from vtctl #9541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vtctl binary Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
requested review from
deepthi and
rohit-nayak-ps
as code owners
|
This bug fix will not work since vtctldserver is also using the same codepath as the vtctl binary when queried with vtctlclient. So, we also start waiting for all replicas on the vtctldserver side which isn't the expected behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running
EmergencyReparentShardfrom the vtctl binary, we used to finish ERS when even 1 replica was successful in reparenting itself to the new primary. When the command finishes, the vtctl binary also finishes execution. This led to the grpc clients for all the other replicas's stopping execution, which in-turn caused the grpc servers to cancel their contexts. In some cases this led to the replication not being setup correctly on some replicas. This PR fixes that issue by adding an additional internal option to running EmergencyReparentShard. When running from vtctl we will wait for all the replicas to return, while we will continue to exit out early for running ERS from vtorc and vtctldserver.Related Issue(s)
Checklist
Deployment Notes