Removing mercurial references. #1

alainjobart · 2013-07-19T17:56:07Z

No description provided.

ryszard · 2013-07-19T19:25:40Z

LGTM 👍

Removing mercurial references.

Merge latest master from upstream

upstream update

Update legacy_split_clone.go

BUG=65416566 When vttablet tries to send a new message to vtgate and receives EOF error, vttablet considers that as a real error and does an exponential back-off for retries. That means when vttablet sits idle for a long time (there are no new messages), and all clients reopened their MessageStream RPCs (which means a lot of dead RPCs due to point #1 above), then when new message arrives vttablet will receive a lot of EOF errors while it tries to send the message over dead RPCs. Due to exponential back-off real delivery of this message will be delayed significantly. If a send returns EOF, the sender does not postpone the messages. Instead, it turns on the messages pending flag and returns. This will cause the poller to be woken up by the send loop as soon as it gets through the cache.

pull

merge

Merging from master

vtbackup: Clean up and add policy enforcement

rebase

Updated test

Signed-off-by: Max Englander <max@planetscale.com>

* decouple olap tx timeout from oltp tx timeout Since workload=olap bypasses the query timeouts (--queryserver-config-query-timeout) and also row limits, the natural assumption is that it also bypasses the transaction timeout. This is not the case, e.g. for a tablet where the --queryserver-config-transaction-timeout is 10. This commit: * Adds new CLI flag and YAML field to independently configure TX timeouts for OLAP workloads (--queryserver-config-olap-transaction-timeout). * Decouples TX kill interval from OLTP TX timeout via new CLI flag and YAML field (--queryserver-config-transaction-killer-interval). Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: pr comments #1 Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: pr comments #2 consolidate timeout logic in sc Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: remove unused tx killer flag Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: update 15_0_0_summary.md Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: fix race cond Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: pr comments #3 -txProps.timeout, +sc.expiryTime Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: pr comments #4 -atomic.Value for expiryTime Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: fix race cond (without atomic.Value) Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: pr comments #5 -unused funcs, fix comments, set ticks interval once Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: pr comments #5 +txkill tests Signed-off-by: Max Englander <max@planetscale.com> * revert fmt changes Signed-off-by: Max Englander <max@planetscale.com> * implement pr review suggestion Signed-off-by: Max Englander <max@planetscale.com> Signed-off-by: Max Englander <max@planetscale.com>

* decouple olap tx timeout from oltp tx timeout Since workload=olap bypasses the query timeouts (--queryserver-config-query-timeout) and also row limits, the natural assumption is that it also bypasses the transaction timeout. This is not the case, e.g. for a tablet where the --queryserver-config-transaction-timeout is 10. This commit: * Adds new CLI flag and YAML field to independently configure TX timeouts for OLAP workloads (--queryserver-config-olap-transaction-timeout). * Decouples TX kill interval from OLTP TX timeout via new CLI flag and YAML field (--queryserver-config-transaction-killer-interval). Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: pr comments vitessio#1 Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: pr comments vitessio#2 consolidate timeout logic in sc Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: remove unused tx killer flag Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: update 15_0_0_summary.md Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: fix race cond Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: pr comments vitessio#3 -txProps.timeout, +sc.expiryTime Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: pr comments vitessio#4 -atomic.Value for expiryTime Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: fix race cond (without atomic.Value) Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: pr comments vitessio#5 -unused funcs, fix comments, set ticks interval once Signed-off-by: Max Englander <max@planetscale.com> * decouple ol{a,t}p tx timeouts: pr comments vitessio#5 +txkill tests Signed-off-by: Max Englander <max@planetscale.com> * fix flags Signed-off-by: Max Englander <max@planetscale.com> Signed-off-by: Max Englander <max@planetscale.com>

* Prevent orphaned VDiffs in two ways... 1. When opening the engine, restart any vdiffs that are in the started state as this indicates it did not complete and was unable to save the final state and must be restarted. 2. When a vdiff run fails, retry saving the error state with an exponential backoff until the engine shuts down. This way the normal retry mechanism will kick in OR #1 will kick in when the engine is next opened on the primary tablet. Signed-off-by: Matt Lord <mattalord@gmail.com> * Handle failures before vdiff_table records are created Signed-off-by: Matt Lord <mattalord@gmail.com> * Add more ephemeral client errors Signed-off-by: Matt Lord <mattalord@gmail.com> * Show vdiff state of error even if no vdiff_table records Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor cleanup Signed-off-by: Matt Lord <mattalord@gmail.com> * Add vdiff2 unit tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Add unit test for retry Signed-off-by: Matt Lord <mattalord@gmail.com> * Small cleanup Signed-off-by: Matt Lord <mattalord@gmail.com> * Addressing review comments and other improvements Signed-off-by: Matt Lord <mattalord@gmail.com> * Use warning log for ... warnings :-) Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor touch ups Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com>

…#11768) (#11943) * Prevent orphaned VDiffs in two ways... 1. When opening the engine, restart any vdiffs that are in the started state as this indicates it did not complete and was unable to save the final state and must be restarted. 2. When a vdiff run fails, retry saving the error state with an exponential backoff until the engine shuts down. This way the normal retry mechanism will kick in OR #1 will kick in when the engine is next opened on the primary tablet. Signed-off-by: Matt Lord <mattalord@gmail.com> * Handle failures before vdiff_table records are created Signed-off-by: Matt Lord <mattalord@gmail.com> * Add more ephemeral client errors Signed-off-by: Matt Lord <mattalord@gmail.com> * Show vdiff state of error even if no vdiff_table records Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor cleanup Signed-off-by: Matt Lord <mattalord@gmail.com> * Add vdiff2 unit tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Add unit test for retry Signed-off-by: Matt Lord <mattalord@gmail.com> * Small cleanup Signed-off-by: Matt Lord <mattalord@gmail.com> * Addressing review comments and other improvements Signed-off-by: Matt Lord <mattalord@gmail.com> * Use warning log for ... warnings :-) Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor touch ups Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com>

Removing mercurial references.

21a4f62

ghost assigned ryszard Jul 19, 2013

alainjobart added a commit that referenced this pull request Jul 19, 2013

Merge pull request #1 from youtube/removing-hg

1be3649

Removing mercurial references.

alainjobart merged commit 1be3649 into master Jul 19, 2013

sougou mentioned this pull request Sep 6, 2015

vitess sql parser can't parse some sql #1078

Closed

alainjobart pushed a commit that referenced this pull request Nov 24, 2016

Merge pull request #1 from youtube/master

8c9b8a2

Merge latest master from upstream

derekperkins mentioned this pull request Dec 15, 2016

First draft for Vitess Queues design document. #2377

Merged

bbeaudreault mentioned this pull request Dec 27, 2016

Fix Impossible Query to account for Group By clauses #2409

Merged

derekperkins mentioned this pull request Jan 23, 2017

Messages User Guide #2493

Merged

demmer added a commit that referenced this pull request Apr 26, 2017

Merge pull request #1 from tinyspeck/upstream-update

304fa02

upstream update

dveeden mentioned this pull request May 7, 2017

Remove references to mercurial #2830

Merged

sougou pushed a commit that referenced this pull request Aug 4, 2017

Merge pull request #1 from xhh1989/xhh1989-patch-1

3e8918e

Update legacy_split_clone.go

sougou mentioned this pull request Sep 11, 2017

messages: fix second part of vttablet bug #3163

Merged

sougou pushed a commit that referenced this pull request Jan 10, 2018

Merge pull request #1 from youtube/master

1095e58

pull

alainjobart unassigned ryszard Mar 1, 2018

sougou pushed a commit that referenced this pull request Jun 21, 2018

Merge pull request #1 from vitessio/master

31acbf1

merge

systay mentioned this pull request Dec 20, 2018

Fix vttablet state transitions #4465

Closed

deepthi mentioned this pull request Jan 28, 2019

Vtctl should have an explicit mode that allows you to force Master to Backup #4557

Closed

sougou pushed a commit that referenced this pull request Feb 24, 2019

Merge pull request #1 from youtube/master

0802077

Merging from master

dkhenry pushed a commit that referenced this pull request Jun 29, 2019

Merge pull request #1 from planetscale/enisoc-vtbackup

3151386

vtbackup: Clean up and add policy enforcement

morgo mentioned this pull request Nov 8, 2019

configuration files for Vitess CLI #4921

Open

mingjianliu added a commit to mingjianliu/vitess that referenced this pull request Mar 6, 2020

Merge pull request vitessio#1 from vitessio/master

7667045

rebase

rohit-nayak-ps mentioned this pull request Jun 10, 2020

RFC: Tracking schema changes in vstreams #6300

Closed

rohit-nayak-ps mentioned this pull request Jan 3, 2021

VStream server-side error during gh-ost online schema migration #7078

Closed

systay pushed a commit that referenced this pull request Jan 20, 2021

Merge pull request #1 from systay/frouioui/master

2d57dab

Updated test

shlomi-noach mentioned this pull request Mar 4, 2021

Suggestions for online DDL query syntax #7604

Closed

prime-minister-of-fun mentioned this pull request May 4, 2021

Adding Permissions to a vitess cluster via vttablet documentation doesn't work. #8036

Open

bravehearto0 mentioned this pull request Jun 22, 2021

Add in clause support for selectDBA statement #8360

Closed

Murali-P mentioned this pull request Jul 16, 2021

Unable to install Vitess on kubernetes (self managed) using operator (Following docs) #8484

Open

derekperkins mentioned this pull request Sep 22, 2021

Vitess doesn't return data if it was inserted directly to an incorrect shard #8860

Closed

doeg mentioned this pull request Feb 14, 2022

RFC: Remove the vtctld2 UI codebase #9686

Closed

rsajwani mentioned this pull request Apr 13, 2022

Bug Report: Zookeeper unit tests are failing on Mac M1 #10093

Closed

vkovacik mentioned this pull request Apr 22, 2022

Bug Report: Unexpected transaction rollback on client session that previously executed GET_LOCK #10130

Closed

mattlord mentioned this pull request Apr 25, 2022

Messaging: Avoid deadlocks related to 0 receiver behavior #10132

Merged

3 tasks

rsajwani mentioned this pull request Aug 16, 2022

Remove prefill logic from resource pool #11002

Merged

3 tasks

maxenglander added a commit to maxenglander/vitess that referenced this pull request Aug 23, 2022

decouple ol{a,t}p tx timeouts: pr comments vitessio#1

035f971

Signed-off-by: Max Englander <max@planetscale.com>

pbibra mentioned this pull request Nov 21, 2022

tablet picker cell alias fallback with local cell preference #11771

Closed

3 tasks

rohit-nayak-ps mentioned this pull request Dec 20, 2022

RFC: VTGate and Tablet Picker: prefer local cells in source tablet selection for vreplication workflows and the VStream API #11999

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing mercurial references. #1

Removing mercurial references. #1

alainjobart commented Jul 19, 2013

ryszard commented Jul 19, 2013

Removing mercurial references. #1

Removing mercurial references. #1

Conversation

alainjobart commented Jul 19, 2013

ryszard commented Jul 19, 2013