[vtadmin-web] Fix default redirect on Tablet view #10010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
ajm188
approved these changes
Mar 30, 2022
notfelineit
reviewed
Mar 30, 2022
| @@ -23,12 +23,26 @@ import { isReadOnlyMode } from '../util/env'; | |||
| * <ReadOnlyGate> | |||
| * <SomeSpicyWriteAction /> | |||
| * </ReadOnlyGate> | |||
| * | |||
| * Do not use ReadOnly gate in a react-router Switch statement as it will break | |||
notfelineit
approved these changes
Mar 30, 2022
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug where the ReadOnlyGate component was breaking redirects when used within a
<Switch>:Turns out my comment was wholly incorrect! Writing these tests took way more time than it was worth! And, best of all, this will likely need to be rewritten when we upgrade to the next version of react-router anyway! 馃ぁ Oh well.
Related Issue(s)
N/A
Checklist
Deployment Notes
N/A