Increase max vrepl workflow source definition size from 64KiB to 16MiB #10018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to avoid practical limits on the number of shard and table definitions in workflows. Signed-off-by: Matt Lord <mattalord@gmail.com>
notfelineit
pushed a commit
to planetscale/vitess
that referenced
this pull request
May 3, 2022
… (vitessio#558) This will allow us to avoid practical limits on the number of shard and table definitions in workflows. Signed-off-by: Matt Lord <mattalord@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you have a large number of tables and or shards involved in a vreplication workflow then you can bump into the existing 64KiB limit for the source definition. Moving the source column to
MEDIUMBLOBincreases the maximum size to 16MiB which should easily cover any reasonable definition.Related Issue(s)
Checklist