Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vtadmin-down.sh from teardown.sh #10136

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Apr 25, 2022

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

This removes vtadmin-down.sh from teardown.sh in order to avoid errors like the following:

cat: ~/go/src/vitess.io/vitess/examples/local/vtdataroot/tmp/vtadmin-web.pid: No such file or directory
./scripts/vtadmin-down.sh: line 6: kill: `': not a pid or valid job spec
Stopping vtadmin-api...
cat: ~/go/src/vitess.io/vitess/examples/local/vtdataroot/tmp/vtadmin-api.pid: No such file or directory
./scripts/vtadmin-down.sh: line 9: kill: `': not a pid or valid job spec

I plan to add vtadmin-up to the local example scripts at the same time as (a) #10118 (to avoid introducing node as a prerequisite for running ./101...) and (b) vitess.io documentation.

Related Issue(s)

N/A

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@doeg doeg merged commit 6bcc5fa into vitessio:main Apr 25, 2022
@doeg doeg deleted the sarabee-no-vtadmin-teardown branch April 25, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants