Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin] non-blocking resolver #10205

Merged

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented May 3, 2022

Description

This PR updates the cluster discovery resolver to make ResolveNow a non-blocking call, by signaling on a channel to watcher goroutine which is continually updating the address list for a cluster component with backoff on failure. It's largely a port of grpc-go's dns-resolver with the "do a dns lookup" replaced with "make a discovery call". (See dns_resolver for reference).

The only notable changes are:

  • I added extra backoff strategies, namely "linear" (which does cur + multiplier instead of exponential's cur * multiplier) and "none" (which never backs-off).
  • I fixed the backoff for exponential and linear, to prevent jittering from exceeding the configured MaxDelay. This is an oversight in grpc-go's implementation as far as I can tell.
  • I added a configuration option to govern the minimum wait time between successful iterations of the watcher loop. In grpc-go this is hard-coded to 30s.
  • I corrected some usages of the timer. The DNS resolver leaks open timer channels in certain conditions.

Related Issue(s)

#9977

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Andrew Mason added 8 commits May 2, 2022 09:01
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
@ajm188 ajm188 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTAdmin VTadmin interface release notes labels May 3, 2022
@ajm188 ajm188 added this to the v14.0 milestone May 3, 2022
@ajm188 ajm188 added this to In progress in VTAdmin via automation May 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link
Contributor

@doeg doeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, though I admit I don't really use channels enough to have a good intuition for them.

I deployed this internally and it works great. ✅


// NOTE: We differ from grpc's exponential backoff here, which actually can
// jitter to a backoff that exceeds the config's MaxDelay, which in my (ajm188)
// opinion is a bug.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A jitterbug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wham! that was a good one

@ajm188 ajm188 merged commit 7420d26 into vitessio:main May 3, 2022
VTAdmin automation moved this from In progress to Done May 3, 2022
@ajm188 ajm188 deleted the andrew/vtadmin/non-blocking-resolver branch May 3, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants