Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the HealthCheckImpl in vtctld instead of the LegacyHealthCheck #10254

Merged
merged 16 commits into from
Jun 6, 2022
Merged

Use the HealthCheckImpl in vtctld instead of the LegacyHealthCheck #10254

merged 16 commits into from
Jun 6, 2022

Commits on May 25, 2022

  1. Initial changes to the vtctld API 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Follow up on the intial vtctld API changes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 25, 2022
    Configuration menu
    Copy the full SHA
    dd2e093 View commit details
    Browse the repository at this point in the history

  2. use healthcheck map in both GetTabletTypesForKeyspaceShardAndCell and… 

    … GetShardInKeyspace

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 25, 2022
    Configuration menu
    Copy the full SHA
    b71940f View commit details
    Browse the repository at this point in the history

  3. move methods from the healthcheck to vtctld's API utils 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 25, 2022
    Configuration menu
    Copy the full SHA
    9bc8b37 View commit details
    Browse the repository at this point in the history

  4. use the HealthCheck interface in vtctld utils 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 25, 2022
    Configuration menu
    Copy the full SHA
    048d59f View commit details
    Browse the repository at this point in the history

  5. use the FakeHealthCheckImpl in vtctld api test 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 25, 2022
    Configuration menu
    Copy the full SHA
    86b095f View commit details
    Browse the repository at this point in the history

  6. Fixed tablet_health JSON 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 25, 2022
    Configuration menu
    Copy the full SHA
    63dc0b0 View commit details
    Browse the repository at this point in the history

  7. Fixed issues in vtctld's heatmap 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 25, 2022
    Configuration menu
    Copy the full SHA
    3c0cebc View commit details
    Browse the repository at this point in the history

  8. Added code comments and fixed format issues 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 25, 2022
    Configuration menu
    Copy the full SHA
    d60599c View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. Apply review suggestions in vtctld api and fake healthcheck 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 27, 2022
    Configuration menu
    Copy the full SHA
    0627f44 View commit details
    Browse the repository at this point in the history

  2. Custom JSON formatter for TabletHealth 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 27, 2022
    Configuration menu
    Copy the full SHA
    3220f80 View commit details
    Browse the repository at this point in the history

  3. Remove Up from TabletHealth 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 27, 2022
    Configuration menu
    Copy the full SHA
    902af79 View commit details
    Browse the repository at this point in the history

  4. Fixed expected output in TestExecutorShow 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 27, 2022
    Configuration menu
    Copy the full SHA
    104d2f5 View commit details
    Browse the repository at this point in the history

  5. Fill the Key and Name fields of the TabletHealth 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 27, 2022
    Configuration menu
    Copy the full SHA
    a196697 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into remove-legacy-healt… 

    …hcheck

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed May 27, 2022
    Configuration menu
    Copy the full SHA
    90b6d2a View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Re ordered the TabletHealth struct as it was before and added a todo … 

    …for v15

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    82d8658 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Merge remote-tracking branch 'upstream/main' into remove-legacy-healt… 

    …hcheck

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    6b9e27d View commit details
    Browse the repository at this point in the history