Improve parser and schemadiff support for ALTER TABLE #10313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
added
Type: Enhancement
dbussink
requested review from
harshit-gangal,
systay and
GuptaManan100
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
The parser logic for ALTER TABLE was not allowing for the INSTANT algorithm. This doesn't implement anything for instant DDL, but it specifically only allows parsing it. Additionally, the new VISIBLE / INVISIBLE property on columns can be set using an `ALTER TABLE ALTER COLUMN`, so this is also added to the parser as well. Lastly, this makes schemadiff work with such an ALTER TABLE statement. It doesn't generate these itself at this point, but implementing support for handling it is simple to add so this was done as well. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
force-pushed
the
parse-instant-algorithm
branch
from
a4f0dfd
to
491fff9
Compare
shlomi-noach
approved these changes
May 16, 2022
dbussink
force-pushed
the
parse-instant-algorithm
branch
from
d869e70
to
dc873d2
Compare
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
force-pushed
the
parse-instant-algorithm
branch
from
dc873d2
to
73052a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser logic for ALTER TABLE was not allowing for the INSTANT algorithm. This doesn't implement anything for instant DDL, but it specifically only allows parsing it.
Additionally, the new VISIBLE / INVISIBLE property on columns can be set using an
ALTER TABLE ALTER COLUMN, so this is also added to the parser as well.Lastly, this makes schemadiff work with such an ALTER TABLE statement. It doesn't generate these itself at this point, but implementing support for handling it is simple to add so this was done as well.
Related Issue(s)
Identified as part of #10203
Checklist