Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logging in GetDurabilityPolicy #10516

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Remove logging in GetDurabilityPolicy #10516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions go/vt/vtctl/grpcvtctldserver/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,7 @@ func (s *VtctldServer) ChangeTabletType(ctx context.Context, req *vtctldatapb.Ch
if err != nil {
return nil, err
}
log.Infof("Getting a new durability policy for %v", durabilityName)
durability, err := reparentutil.GetDurabilityPolicy(durabilityName)
if err != nil {
return nil, err
Expand Down Expand Up @@ -1744,6 +1745,7 @@ func (s *VtctldServer) InitShardPrimaryLocked(
if err != nil {
return err
}
log.Infof("Getting a new durability policy for %v", durabilityName)
durability, err := reparentutil.GetDurabilityPolicy(durabilityName)
if err != nil {
return err
Expand Down Expand Up @@ -2318,6 +2320,7 @@ func (s *VtctldServer) ReparentTablet(ctx context.Context, req *vtctldatapb.Repa
if err != nil {
return nil, err
}
log.Infof("Getting a new durability policy for %v", durabilityName)
durability, err := reparentutil.GetDurabilityPolicy(durabilityName)
if err != nil {
return nil, err
Expand Down Expand Up @@ -2986,6 +2989,7 @@ func (s *VtctldServer) StartReplication(ctx context.Context, req *vtctldatapb.St
if err != nil {
return nil, err
}
log.Infof("Getting a new durability policy for %v", durabilityName)
durability, err := reparentutil.GetDurabilityPolicy(durabilityName)
if err != nil {
return nil, err
Expand Down Expand Up @@ -3084,6 +3088,7 @@ func (s *VtctldServer) TabletExternallyReparented(ctx context.Context, req *vtct
if err != nil {
return nil, err
}
log.Infof("Getting a new durability policy for %v", durabilityName)
durability, err := reparentutil.GetDurabilityPolicy(durabilityName)
if err != nil {
return nil, err
Expand Down
1 change: 0 additions & 1 deletion go/vt/vtctl/reparentutil/durability.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ func GetDurabilityPolicy(name string) (Durabler, error) {
if !found {
return nil, fmt.Errorf("durability policy %v not found", name)
}
log.Infof("Getting a new durability policy for %v", name)
return newDurabilityCreationFunc(), nil
}

Expand Down
1 change: 1 addition & 0 deletions go/vt/vtctl/reparentutil/emergency_reparenter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ func (erp *EmergencyReparenter) reparentShardLocked(ctx context.Context, ev *eve
return err
}

erp.logger.Infof("Getting a new durability policy for %v", keyspaceDurability)
opts.durability, err = GetDurabilityPolicy(keyspaceDurability)
if err != nil {
return err
Expand Down
1 change: 1 addition & 0 deletions go/vt/vtctl/reparentutil/planned_reparenter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,7 @@ func (pr *PlannedReparenter) reparentShardLocked(
return err
}

pr.logger.Infof("Getting a new durability policy for %v", keyspaceDurability)
opts.durability, err = GetDurabilityPolicy(keyspaceDurability)
if err != nil {
return err
Expand Down
1 change: 1 addition & 0 deletions go/vt/vtctl/reparentutil/replication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ func SetReplicationSource(ctx context.Context, ts *topo.Server, tmc tmclient.Tab
if err != nil {
return err
}
log.Infof("Getting a new durability policy for %v", durabilityName)
durability, err := GetDurabilityPolicy(durabilityName)
if err != nil {
return err
Expand Down
1 change: 1 addition & 0 deletions go/vt/wrangler/reparent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ func (wr *Wrangler) TabletExternallyReparented(ctx context.Context, newPrimaryAl
if err != nil {
return err
}
log.Infof("Getting a new durability policy for %v", durabilityName)
durability, err := reparentutil.GetDurabilityPolicy(durabilityName)
if err != nil {
return err
Expand Down