-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: more unrecoverable error codes #10559
VReplication: more unrecoverable error codes #10559
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Code changes look good, but I see some onlineddl workflows are failing. They are rerunning now, and the errors looked as if they were not related to this change, so approving.
@shlomi-noach as a bugfix, would this also be eligible to backport to the 14 release branch as well? |
I think so! |
yes, there is increased flakiness lately, which I don't have good explanation for, yet. |
Ohhhh. The |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* VReplication: more unrecoverable error codes Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * correct path for test files Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…io#781) * VReplication: more unrecoverable error codes Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * correct path for test files Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Description
followup to #9973, #10390, #10394
Adding error codes related to
DATETIME
value conversion/truncation. This will fail aVReplication
workflow, and specifically an Online DDLvitess
migration, immediately upon receipt of such error.Related Issue(s)
#6926
Checklist
Deployment Notes