Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: more unrecoverable error codes #10559

Conversation

shlomi-noach
Copy link
Contributor

Description

followup to #9973, #10390, #10394

Adding error codes related to DATETIME value conversion/truncation. This will fail a VReplication workflow, and specifically an Online DDL vitess migration, immediately upon receipt of such error.

Related Issue(s)

#6926

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@github-actions
Copy link
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Code changes look good, but I see some onlineddl workflows are failing. They are rerunning now, and the errors looked as if they were not related to this change, so approving.

@dbussink
Copy link
Contributor

@shlomi-noach as a bugfix, would this also be eligible to backport to the 14 release branch as well?

@shlomi-noach
Copy link
Contributor Author

would this also be eligible to backport to the 14 release branch as well?

I think so!

@shlomi-noach
Copy link
Contributor Author

but I see some onlineddl workflows are failing.

yes, there is increased flakiness lately, which I don't have good explanation for, yet.

@shlomi-noach
Copy link
Contributor Author

Ohhhh. The vrepl tests are failing because I accidentally committed a temp directory into the test suite. Removing it.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach merged commit 1387cfb into vitessio:main Jun 22, 2022
@shlomi-noach shlomi-noach deleted the vreplication-online-ddl-more-unrecoverable-codes branch June 22, 2022 08:04
shlomi-noach added a commit to planetscale/vitess that referenced this pull request Jun 22, 2022
* VReplication: more unrecoverable error codes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* correct path for test files

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach added a commit that referenced this pull request Jun 22, 2022
* VReplication: more unrecoverable error codes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* correct path for test files

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
rsajwani pushed a commit to planetscale/vitess that referenced this pull request Jun 27, 2022
…io#781)

* VReplication: more unrecoverable error codes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* correct path for test files

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants