Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online DDL: more support for INSTANT DDL #11591

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Online DDL: more support for INSTANT DDL #11591

merged 2 commits into from
Oct 27, 2022

Conversation

shlomi-noach
Copy link
Contributor

Description

Followup to #10402, in this PR:

  • INSTANT DDL is supported by ddl_strategy flag --prefer-instant-ddl
  • Added support for ENUM/SET instant DDLs
  • A minor validation for DROP COLUMN (INSTANT not supported in COMPRESSED tables)

As reminders/context:

  • MySQL supports INSTANT DDL for some limited types of ALTER TABLE operations
  • When --prefer-instant-ddl is specified, we capture and analyze those specific operations
  • If applicable to INSTANT, we add ALGORITHM=INSTANT and run the schema migration directly, and do not pass it through to gh-ost nor vitess/vreplication.
  • Schema changes executed with INSTANT algorithm are non-revertible.

Related Issue(s)

Tracking: #6926

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach
Online DDL: support instant DDL for enum changes; strategy flag now c…
cfdc1a7 
…alled '--prefer-instant-ddl'

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach requested review from dbussink and a team October 27, 2022 07:50
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 27, 2022 •
edited by dbussink

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

dbussink
dbussink approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny spelling nit 😄

go/vt/vttablet/onlineddl/analysis_test.go Outdated
version: "8.0.21",
create: "create table t(id int, i1 int not null, primary key(id))",
alter: "alter table t modify column i1 int default null",
instant: false,
},
{
// fail because on top of changing the default valuem, the datatype is changed, too
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type with valuem

@shlomi-noach
typo
d882899 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Oct 27, 2022
@shlomi-noach shlomi-noach merged commit 6ac536c into vitessio:main Oct 27, 2022
@shlomi-noach shlomi-noach deleted the online-ddl-more-instant-ddl branch October 27, 2022 11:37
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Nov 16, 2022
@shlomi-noach
Online DDL: more support for INSTANT DDL (vitessio#11591) (vitessio#1229
baf7f63 
)

* Online DDL: support instant DDL for enum changes; strategy flag now called '--prefer-instant-ddl'

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* typo

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
dbussink pushed a commit that referenced this pull request Jan 30, 2023
@shlomi-noach @rohit-nayak-ps
Online DDL: more support for INSTANT DDL (#11591) (#1229)
6bbf926 
* Online DDL: support instant DDL for enum changes; strategy flag now called '--prefer-instant-ddl'

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* typo

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach mentioned this pull request Apr 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbussink dbussink dbussink approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@deepthi deepthi Awaiting requested review from deepthi

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shlomi-noach @dbussink