Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release of v16.0.0-rc1 #12235

Merged
merged 2 commits into from Feb 8, 2023
Merged

Release of v16.0.0-rc1 #12235

merged 2 commits into from Feb 8, 2023

Conversation

GuptaManan100
Copy link
Member

Includes the release notes and release commit for the v16.0.0-rc1 release. Once this PR is merged, we will be able to tag v16.0.0-rc1 on the merge commit.

@GuptaManan100
Release notes for 16.0.0-rc1
c10b433 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
Release commit for 16.0.0-rc1
9fde553 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Component: General Changes throughout the code base Type: Release labels Feb 3, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 3, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 3, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui added Do Not Merge and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 3, 2023
frouioui
frouioui approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me. Not merging this now as we wait until RC-1's release day, which is on February 7.

mattlord
mattlord approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I had only very minor nits. If you like we can leave it as-is or I can push a commit to address my own nits if you want. Thanks!

doc/releasenotes/16_0_0_changelog.md
* Add support for Views DDL [#11896](https://github.com/vitessio/vitess/pull/11896)
* notify view change to vtgate [#12115](https://github.com/vitessio/vitess/pull/12115)
* Views Support: Updating Views in VSchema for query serving [#12124](https://github.com/vitessio/vitess/pull/12124)
#### web UI
Copy link
Contributor

@mattlord mattlord Feb 7, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, we should use title capitalization for the section headers. I also think Admin Web UI would be more accurate.

doc/releasenotes/16_0_0_changelog.md
* VReplication: Remove Deprecated V1 Client Commands [#11705](https://github.com/vitessio/vitess/pull/11705)
#### VTAdmin
* move react-scripts to dev dependencies [#11767](https://github.com/vitessio/vitess/pull/11767)
#### web UI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Web UI. IMO, it probably also makes sense to use Admin Web UI to make this a bit more specific (in all locations).

doc/releasenotes/16_0_0_release_notes.md

#### 'mysql' strategy
## <a id="major-changes"/> Major Changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space here.

doc/releasenotes/16_0_0_release_notes.md
- A server restored to a point in time remains in `DRAINED` tablet type, and does not join the replication stream (thus, "frozen" in time).
- It is possible to take incremental backups from different tablets. It is OK to have overlaps in incremental backup contents. The restore process chooses a valid path, and is valid as long as there are no gaps in the backed up binary log content.

### <a id="repl-manager-removal"/> Replication manager removal and VTOrc becomes mandatory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra spaces in a bunch of these from here.

doc/releasenotes/16_0_0_release_notes.md

The default major MySQL version used by our `vitess/lite:latest` image is going from `5.7` to `8.0`. Additionally, the default patch version of the `vitess/lite:mysql80` image goes from `8.0.23` to `8.0.31`.

#### <a id="vtcltd-ui-removal"/> vtctld UI Removal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should say Web UI.

doc/releasenotes/16_0_0_release_notes.md

This will allow users to start a transaction with these characteristics.

#### <a id="support-views"/> Support for views
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using title capitalization here.

doc/releasenotes/16_0_0_release_notes.md

## <a id="minor-changes"/> Minor changes

### <a id="backup-comp-benchmarks"/> Backup compression benchmarks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No title capitalization again.

doc/releasenotes/16_0_0_release_notes.md

## <a id="refactor"/> Refactor

### <a id="vttablet-sidecar-schema"/> VTTablet sidecar schema maintenance refactor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again :-)

@GuptaManan100
Copy link
Member Author

Merging this PR and will address reviews in a separate PR.

@GuptaManan100 GuptaManan100 merged commit 5334b22 into vitessio:release-16.0 Feb 8, 2023
@GuptaManan100 GuptaManan100 deleted the release-16.0-create_release-1 branch February 8, 2023 15:04
@GuptaManan100 GuptaManan100 mentioned this pull request Feb 8, 2023
Merged
3 tasks
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlord mattlord mattlord approved these changes

@frouioui frouioui frouioui approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

@rsajwani rsajwani Awaiting requested review from rsajwani rsajwani is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Do Not Merge Type: Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GuptaManan100 @mattlord @frouioui