Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Fix Vtop example and release script #12440

Merged
merged 5 commits into from Feb 23, 2023

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Feb 23, 2023

Description

Since the default images are now MySQL 8.0, we need to update the operator example to use the right property for the image.

This PR also fixes the image we use for vtadmin deployment and fixes the release script to also change that automatically.
Further the vtop example script is fixed to use vtctldclient inplace of vtctlclient.

Related Issue(s)

Fixes #12438

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: deepthi <deepthi@planetscale.com>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 23, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 23, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@deepthi
Copy link
Member Author

deepthi commented Feb 23, 2023

I noticed that vtadmin image still has latest. Did we not build an rc1 image for it?

@deepthi deepthi added Component: Examples Type: Bug and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 23, 2023
@deepthi
Copy link
Member Author

deepthi commented Feb 23, 2023

This needs to be fixed on main as well, but I doubt the bot can do it. It will need a hand-crafted PR.

@frouioui frouioui added the Forwardport to: main This will forward port the PR to the main branch label Feb 23, 2023
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui mentioned this pull request Feb 23, 2023
51 tasks
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 changed the title examples: should use mysql80 property for vitess image examples: Fix Vtop example and release script Feb 23, 2023
@GuptaManan100 GuptaManan100 merged commit c37bdd7 into vitessio:release-16.0 Feb 23, 2023
@GuptaManan100 GuptaManan100 deleted the ds-op-ex branch February 23, 2023 11:32
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 23, 2023

I was unable to forwardport this Pull Request to the following branches: main.

@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Examples Forwardport to: main This will forward port the PR to the main branch Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants