New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: Fix Vtop example and release script #12440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
requested review from
GuptaManan100,
frouioui and
mattlord
as code owners
February 23, 2023 00:20
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
labels
Feb 23, 2023
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
I noticed that |
deepthi
added
Component: Examples
Type: Bug
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
labels
Feb 23, 2023
This needs to be fixed on |
frouioui
added
the
Forwardport to: main
This will forward port the PR to the main branch
label
Feb 23, 2023
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
requested review from
rohit-nayak-ps and
harshit-gangal
as code owners
February 23, 2023 09:03
GuptaManan100
approved these changes
Feb 23, 2023
GuptaManan100
changed the title
examples: should use mysql80 property for vitess image
examples: Fix Vtop example and release script
Feb 23, 2023
frouioui
approved these changes
Feb 23, 2023
I was unable to forwardport this Pull Request to the following branches: |
4 tasks
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the default images are now MySQL 8.0, we need to update the operator example to use the right property for the image.
This PR also fixes the image we use for vtadmin deployment and fixes the release script to also change that automatically.
Further the vtop example script is fixed to use
vtctldclient
inplace ofvtctlclient
.Related Issue(s)
Fixes #12438
Checklist
Deployment Notes