Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tx throttler: healthcheck all cells if --tx-throttler-healthcheck-cells is undefined #12477

Merged
merged 33 commits into from
Jul 31, 2023
Merged

tx throttler: healthcheck all cells if --tx-throttler-healthcheck-cells is undefined #12477

merged 33 commits into from
Jul 31, 2023

Commits on Feb 24, 2023

  1. WIP 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    1fecb5d View commit details
    Browse the repository at this point in the history

  2. vttablet tx throttler: healthcheck all cells if cells unspecified 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    6beae70 View commit details
    Browse the repository at this point in the history

  3. Fix test typo 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    c8ad379 View commit details
    Browse the repository at this point in the history

  4. Simplify test 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    6ed1bac View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. remove unnecessary 'empty healthCheckCells given' error 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    4c04f24 View commit details
    Browse the repository at this point in the history

  2. last tweak to simplify test 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    08c1a1d View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Update go/vt/vttablet/tabletserver/txthrottler/tx_throttler.go 

    Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt @shlomi-noach
    timvaillancourt and shlomi-noach committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    0dd51b8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into tx-throtter-default-all-cells 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    25bf05b View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Merge branch 'main' into tx-throtter-default-all-cells 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed May 17, 2023
    Configuration menu
    Copy the full SHA
    62a9a26 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2023

  1. Merge branch 'main' into tx-throtter-default-all-cells 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    71ea246 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Move .GetKnownCells() call to .Open() 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    ed439e4 View commit details
    Browse the repository at this point in the history

  2. Update test 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    d5c87cc View commit details
    Browse the repository at this point in the history

  3. Improve err message 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    84e0a4a View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Add code comment to explain 2nd cell check 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9887e9f View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2023

  1. Add func fetchKnownCells() 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    90d15b0 View commit details
    Browse the repository at this point in the history

  2. Add test for fetchKnownCells 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    abc694d View commit details
    Browse the repository at this point in the history

  3. Restart health stream if topo cells change 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    1cf084d View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. Update cell list when changed 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    29c496a View commit details
    Browse the repository at this point in the history

  2. log.Fatalf -> Errorf 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    a0698dd View commit details
    Browse the repository at this point in the history

  3. Improve test 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    8b287b8 View commit details
    Browse the repository at this point in the history

  4. use defer to stop ticker 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    0e8ae6f View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. PR suggestion 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    ab35c8b View commit details
    Browse the repository at this point in the history

  2. Add cellsFromTopo bool to txThrottlerState 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    2f5c44d View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. pass context.Context to .fetchKnownCells(...) 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    e7fa178 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. merge main 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d88c453 View commit details
    Browse the repository at this point in the history

  2. PR suggestion 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    e25e5ef View commit details
    Browse the repository at this point in the history

  3. fix defer-cancel() in loop 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    42bba79 View commit details
    Browse the repository at this point in the history

  4. Past context to updateHealthCheckCells 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    e616a92 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. PR feedback 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    2a879ad View commit details
    Browse the repository at this point in the history

  2. Dont update cells in config 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    4d8bff0 View commit details
    Browse the repository at this point in the history

  3. Add "the" to cli flag help + force ci to run again 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e7ac2c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Missing ts.config -> ts.config.healthCheckCells 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    b70a1fa View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. Fix unit test failure 

    Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
    @timvaillancourt
    timvaillancourt committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    616f4a6 View commit details
    Browse the repository at this point in the history