Throttler: Store Config in Global Keyspace Topo Record #12520

mattlord · 2023-02-28T19:49:26Z

Description

Related Issue(s)

Fixes: Bug Report: Throttler Config Via Topo Is Broken #12523

Checklist

"Backport to:" labels have been added if this change should be back-ported
Tests were added or are not required
Did the new or modified tests pass consistently locally and on the CI
Documentation was added or is not required

Signed-off-by: Matt Lord <mattalord@gmail.com>

vitess-bot · 2023-02-28T19:49:29Z

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

Ensure that the Pull Request has a descriptive title.
If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

Is it really necessary to add this flag?
Flag names should be clear and intuitive (as far as possible)
Help text should be descriptive.
Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

Each item in Jobs should be named in order to mark it as required.
If the workflow should be required, the maintainer team should be notified.

Bug fixes

There should be at least one unit or end-to-end test.
The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

There should be some code comments as to why things are implemented the way they are.

New/Existing features

Should be documented, either by modifying the existing documentation or creating new documentation.
New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

Protobuf changes should be wire-compatible.
Changes to _vt tables and RPCs need to be backward compatible.
vtctl command output order should be stable and awk-able.
RPC changes should be compatible with vitess-operator
If a flag is removed, then it should also be removed from VTop, if used there.

Signed-off-by: Matt Lord <mattalord@gmail.com>

We should not ever make an assumption about how quickly an operation will take. Signed-off-by: Matt Lord <mattalord@gmail.com>

Signed-off-by: Matt Lord <mattalord@gmail.com>

shlomi-noach

Thank you for this! I think the main question (also found inline): if we update SrvKeyspace, and that in turn updates Keyspace, does the change propagate back down to all other SrvKeyspaces? Should it? Let's discuss.

go/vt/vttablet/tabletserver/throttle/throttler.go

proto/topodata.proto

go/vt/vtctl/vtctl.go

go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach

I've applied a few minor suggestions (remove excessive waits in testing; use context for timeout) -- let's merge this! (assuming tests are good)

deepthi · 2023-03-08T19:11:00Z

Both the test failures are flaky and there are people looking into them.

deepthi · 2023-03-08T19:14:36Z

I applied the Backport: label to take advantage of the bot. If we decide not to put this into release-16.0 we can close the bot-created PR.

…#12520) (#12576) * Store throttler config in global Keyspace record Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix unit test after ThrottlerConfig in Keyspace Signed-off-by: Matt Lord <mattalord@gmail.com> * Apply changes lost in cherry picks Signed-off-by: Matt Lord <mattalord@gmail.com> * Always wait for a status before the final check. We should not ever make an assumption about how quickly an operation will take. Signed-off-by: Matt Lord <mattalord@gmail.com> * Propagate PartialResult and other errs back to client Signed-off-by: Matt Lord <mattalord@gmail.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vtctlutil.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vtgate_util.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * fix grammar Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Move to Go 1.19 atomics (vitessio#12391) * Move to Go 1.19 atomics This change moves to Go 1.19 atomics in favor of the version we had in the `sync2` package. The version in that package predates the availability of the new atomics, but for the future we want to use the Go provided ones. On top of that, we can also use the semaphore from `x/sync` instead of a custom one in `sync2`. This cleans up a bunch of additional code from `sync2`. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Don't assume the value is a duration This can be any float, so we need to store the float bits in an atomic uint64 instead (as Go has no atomic floats). Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Log actual error if acquiring semaphore fails Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Fix overlooked metrics threshold case Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com> * [release-16.0] Throttler: Store Config in Global Keyspace Topo Record (vitessio#12520) (vitessio#12576) * Store throttler config in global Keyspace record Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix unit test after ThrottlerConfig in Keyspace Signed-off-by: Matt Lord <mattalord@gmail.com> * Apply changes lost in cherry picks Signed-off-by: Matt Lord <mattalord@gmail.com> * Always wait for a status before the final check. We should not ever make an assumption about how quickly an operation will take. Signed-off-by: Matt Lord <mattalord@gmail.com> * Propagate PartialResult and other errs back to client Signed-off-by: Matt Lord <mattalord@gmail.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vtctlutil.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Update go/test/endtoend/onlineddl/vtgate_util.go Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * fix grammar Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Flakes: Use new healthy shard check in vreplication e2e tests (vitessio#12502) * Use new healthy shard check in vreplication e2e tests This is needed because checking that there's a primary tablet for the shard in vtgate's healtcheck is no longer a reliable indicator that the shard has a healthy serving primary, because now a primary needs to initialize its sidecar database and wait for that to replicate via semi-sync before it becomes serving and can proceed to perform normal functions. So this delay could cause test flakiness if you required a healthy shard before continuing with the test. Signed-off-by: Matt Lord <mattalord@gmail.com> * Try to address unit test race flakes around log size They looked like this: WARNING: DATA RACE Write at 0x000005bf9b60 by goroutine 27141: github.com/spf13/pflag.newUint64Value() /home/runner/go/pkg/mod/github.com/spf13/pflag@v1.0.5/uint64.go:9 +0x5a github.com/spf13/pflag.(*FlagSet).Uint64Var() /home/runner/go/pkg/mod/github.com/spf13/pflag@v1.0.5/uint64.go:45 +0x55 vitess.io/vitess/go/vt/log.RegisterFlags() /home/runner/work/vitess/vitess/go/vt/log/log.go:81 +0x64 vitess.io/vitess/go/vt/servenv.GetFlagSetFor() /home/runner/work/vitess/vitess/go/vt/servenv/servenv.go:347 +0x183 vitess.io/vitess/go/vt/servenv.ParseFlags() /home/runner/work/vitess/vitess/go/vt/servenv/servenv.go:326 +0x49 ... Previous read at 0x000005bf9b60 by goroutine 27136: 1744 github.com/golang/glog.(*syncBuffer).Write() ... And they most often occurred in the wrangler unit tests, which makes sense because it creates a log of loggers. Signed-off-by: Matt Lord <mattalord@gmail.com> * Revert "Try to address unit test race flakes around log size" This reverts commit 51992b8. Signed-off-by: Matt Lord <mattalord@gmail.com> * Use external cluster vtctld in TestMigrate Signed-off-by: Matt Lord <mattalord@gmail.com> * Use subshell vs command output interpolation Signed-off-by: Matt Lord <mattalord@gmail.com> * Ingnore any config files in mysql alias Signed-off-by: Matt Lord <mattalord@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> * Support Custom SidecarDB Names on VTTablets (vitessio#12240) * WIP Signed-off-by: Matt Lord <mattalord@gmail.com> * vreplication package Signed-off-by: Matt Lord <mattalord@gmail.com> * Revert OnlineDDL package changes for now Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix unit tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix InitShardPrimary / ReparentJournal Signed-off-by: Matt Lord <mattalord@gmail.com> * onlineddl package Signed-off-by: Matt Lord <mattalord@gmail.com> * Shorten/improve exported func name Signed-off-by: Matt Lord <mattalord@gmail.com> * Remaining work Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove redundancy from exported function names Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor changes after self review Signed-off-by: Matt Lord <mattalord@gmail.com> * More testing, more fixes Signed-off-by: Matt Lord <mattalord@gmail.com> * Move from vttablet flag to topo Keyspace record Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix vtctld API unit test Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix TestHelp Signed-off-by: Matt Lord <mattalord@gmail.com> * Update throttler service initialization Signed-off-by: Matt Lord <mattalord@gmail.com> * Use custom sidecar in VReplication e2e tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Make sidecardb name concurrecy safe Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix VDiff2 e2e test and remove other hardecoded sidecar names Signed-off-by: Matt Lord <mattalord@gmail.com> * Adjust throttler initialization Signed-off-by: Matt Lord <mattalord@gmail.com> * Post merge fixes Signed-off-by: Matt Lord <mattalord@gmail.com> * Copy SidecarDBName from global Keyspace object to SrvKeyspace objects This way it can be easily accessed by vtgate, vtctld, etc via their existing ResilentServer SrvKeyspace watchers in their own local cell. Signed-off-by: Matt Lord <mattalord@gmail.com> * Store throttler config in global Keyspace record Signed-off-by: Matt Lord <mattalord@gmail.com> * Update vtadmin protos Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix unit test after ThrottlerConfig in Keyspace Signed-off-by: Matt Lord <mattalord@gmail.com> * SidecarDbName is not needed in SrvKeyspace records Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove sqlparser.ReplaceTableQualifiers from query hot path. Signed-off-by: Matt Lord <mattalord@gmail.com> * Add topo timeout for SHOW VITESS_MIGRATIONS Signed-off-by: Matt Lord <mattalord@gmail.com> * Cache sidecar database identifiers by keyspace Signed-off-by: Matt Lord <mattalord@gmail.com> * Modify onlineddl package 1. Move sidecardb table qualifier mgmt to execQuery() 2. Move e2e test back to tablet flag based throttler config Signed-off-by: Matt Lord <mattalord@gmail.com> * Revert "Fix unit test after ThrottlerConfig in Keyspace" This reverts commit 303db96. Signed-off-by: Matt Lord <mattalord@gmail.com> * Revert "Store throttler config in global Keyspace record" This reverts commit 1e7c750. Signed-off-by: Matt Lord <mattalord@gmail.com> * Finish ThrottlerTopoConfig change rollback Signed-off-by: Matt Lord <mattalord@gmail.com> * Add max identifier length check for --sidecar-db-name flag Signed-off-by: Matt Lord <mattalord@gmail.com> * Move vdiff and vreplication packages to binlogplayer.DBClient.ExecuteFetch() Signed-off-by: Matt Lord <mattalord@gmail.com> * binlogplayer.DBClient: eliminate overhead when default name is used Signed-off-by: Matt Lord <mattalord@gmail.com> * Move keyspace ID look to a helper function In case it needs to be used elsewhere. Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor cleanup Signed-off-by: Matt Lord <mattalord@gmail.com> * Add context for usage in the local examples Signed-off-by: Matt Lord <mattalord@gmail.com> * Correct CreateKeyspace command's sidecardb flag validation Signed-off-by: Matt Lord <mattalord@gmail.com> * Limit overhead for OnlineDDL package Signed-off-by: Matt Lord <mattalord@gmail.com> * Cleanup and improvements after self review Signed-off-by: Matt Lord <mattalord@gmail.com> * Store each keyspace's sidecar db identifier in schema.Tracker Signed-off-by: Matt Lord <mattalord@gmail.com> * Enable custom sidecar db name in schema tracker e2e tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix schema.tracker and its tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Better support downgrade tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Always use sqlparser.String() for proper escaping Signed-off-by: Matt Lord <mattalord@gmail.com> * Try to fix Upgrade Downgrade Testing Query Serving (Schema) Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor changes after self review. Signed-off-by: Matt Lord <mattalord@gmail.com> * Mark new flag/functionality as experimental Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove exclamation point from example error msg Signed-off-by: Matt Lord <mattalord@gmail.com> * Fixups after merge Signed-off-by: Matt Lord <mattalord@gmail.com> * More post merge fixes Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Moar knits! Signed-off-by: Matt Lord <mattalord@gmail.com> * Moar knits -- the sequel Signed-off-by: Matt Lord <mattalord@gmail.com> * Deflake schematracker e2e tests They have gotten flakier since the tablet init changes. Signed-off-by: Matt Lord <mattalord@gmail.com> * Add a dedicated in-memory cache for sidecar db idents Signed-off-by: Matt Lord <mattalord@gmail.com> * Improve sidecardb identifier cache Signed-off-by: Matt Lord <mattalord@gmail.com> * More minor improvements Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor tweaks after final self review Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor tidy work Signed-off-by: Matt Lord <mattalord@gmail.com> * Delete entry from cache on srvkeyspace deletion Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments. Signed-off-by: Matt Lord <mattalord@gmail.com> * Save me from my nitting! (use vtrpcpb convention) Signed-off-by: Matt Lord <mattalord@gmail.com> * Make IdentifierCache more concurrency-safe than it needs to be (today) Signed-off-by: Matt Lord <mattalord@gmail.com> * Slighly improve code coverage Signed-off-by: Matt Lord <mattalord@gmail.com> * Let caller know if New created a cache or returned inited singleton. Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Use more unique name for unit test Signed-off-by: Matt Lord <mattalord@gmail.com> * Address latest review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Use lower context for updating keyspace Signed-off-by: Matt Lord <mattalord@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> * Adjust version checks in test utils Signed-off-by: Matt Lord <mattalord@gmail.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Store throttler config in global Keyspace record

89727e9

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord added Type: Bug Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Feb 28, 2023

vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 28, 2023

mattlord requested a review from shlomi-noach February 28, 2023 19:49

Fix unit test after ThrottlerConfig in Keyspace

ce34f61

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the throttler_topo_fixes branch from bf67af0 to ce34f61 Compare February 28, 2023 19:53

mattlord mentioned this pull request Feb 28, 2023

Bug Report: Throttler Config Via Topo Is Broken #12523

Closed

Apply changes lost in cherry picks

b4c347f

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the throttler_topo_fixes branch from baf15a0 to b4c347f Compare March 1, 2023 00:47

mattlord added 2 commits February 28, 2023 21:19

Always wait for a status before the final check.

7c1e958

We should not ever make an assumption about how quickly an operation will take. Signed-off-by: Matt Lord <mattalord@gmail.com>

Propagate PartialResult and other errs back to client

a0d612e

Signed-off-by: Matt Lord <mattalord@gmail.com>

shlomi-noach reviewed Mar 7, 2023

View reviewed changes

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

287921e

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach added the Skip CI Skip CI actions from running label Mar 8, 2023

shlomi-noach added 13 commits March 8, 2023 07:48

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

06bec1a

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

5d6185b

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

07925c6

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

9cc9176

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

69e53fb

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

26c4390

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

e4dce19

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

3ff4fd5

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

e58832e

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

6d129c9

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

9ef565b

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

c45fea5

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

e570fab

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach added 2 commits March 8, 2023 07:55

Update go/test/endtoend/onlineddl/vtgate_util.go

3e4304c

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

fix grammar

e9b0d3a

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

shlomi-noach removed the Skip CI Skip CI actions from running label Mar 8, 2023

shlomi-noach marked this pull request as ready for review March 8, 2023 05:58

shlomi-noach requested review from deepthi, harshit-gangal, systay, rohit-nayak-ps, ajm188, notfelineit and rsajwani as code owners March 8, 2023 05:58

shlomi-noach approved these changes Mar 8, 2023

View reviewed changes

deepthi removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 8, 2023

deepthi approved these changes Mar 8, 2023

View reviewed changes

deepthi added the Backport to: release-16.0 label Mar 8, 2023

deepthi merged commit 0817f32 into vitessio:main Mar 8, 2023

deepthi deleted the throttler_topo_fixes branch March 8, 2023 19:14

vitess-bot bot mentioned this pull request Mar 8, 2023

[release-16.0] Throttler: Store Config in Global Keyspace Topo Record (#12520) #12576

Merged

mattlord mentioned this pull request Apr 20, 2023

Feature Request: GetThrottlerConfig vtctld RPC #12925

Closed

shlomi-noach mentioned this pull request Apr 20, 2023

Bug Report: vtctlclient -- UpdateThrottlerConfig only updates SrvKeyspace but not Keyspace #12935

Closed

shlomi-noach mentioned this pull request May 23, 2023

Tablet throttler: throttler-config-via-topo defaults 'true', deprecation message for old flags #13130

Merged

4 tasks

This was referenced May 31, 2023

Tablet throttler: throttler-config-via-topo defaults 'true', deprecation message for old flags (alternate) #13202

Closed

Backport #13130: Tablet throttler: throttler-config-via-topo defaults 'true', deprecation message for old flags #13237

Merged

hmaurer mentioned this pull request Mar 21, 2024

oops #15542

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Throttler: Store Config in Global Keyspace Topo Record #12520

Throttler: Store Config in Global Keyspace Topo Record #12520

mattlord commented Feb 28, 2023 •

edited

vitess-bot bot commented Feb 28, 2023

shlomi-noach left a comment

shlomi-noach left a comment •

edited

deepthi commented Mar 8, 2023

deepthi commented Mar 8, 2023

Throttler: Store Config in Global Keyspace Topo Record #12520

Throttler: Store Config in Global Keyspace Topo Record #12520

Conversation

mattlord commented Feb 28, 2023 • edited

Description

Related Issue(s)

Checklist

vitess-bot bot commented Feb 28, 2023

Review Checklist

General

If a new flag is being introduced:

If a workflow is added or modified:

Bug fixes

Non-trivial changes

New/Existing features

Backward compatibility

shlomi-noach left a comment

Choose a reason for hiding this comment

shlomi-noach left a comment • edited

Choose a reason for hiding this comment

deepthi commented Mar 8, 2023

deepthi commented Mar 8, 2023

mattlord commented Feb 28, 2023 •

edited

shlomi-noach left a comment •

edited