Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dubious ownership of git directory in vitess/base Docker build #12530

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Fix dubious ownership of git directory in vitess/base Docker build #12530

merged 3 commits into from
Mar 7, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Mar 1, 2023 •
edited

Description

This Pull Request adds the COPY --chown=vitess:vitess . /vt/src/vitess.io/vitess to our vitess/base Dockerfile in order to trust the git directory.

Related Issue(s)

Fixes #12529

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@frouioui
Fix dubious ownership of git directory in vitess/base Docker build
1931788 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 1, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 1, 2023 •
edited by deepthi

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 1, 2023
@frouioui
Use consistent method to copy and build vitess between base and lite
fc7d57e 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
arthurschreiber
arthurschreiber approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@arthurschreiber arthurschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Can you also update the PR description to match? 🙇

deepthi
deepthi reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed after approving that there are two more Dockerfiles in this directory, which also need to fixed.
Can you fix them both and include that in this PR before merging?

@frouioui
fix all base Dockerfiles
e98f9f2 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui merged commit 81b406d into vitessio:main Mar 7, 2023
@frouioui frouioui deleted the fix-docker-base-build branch March 7, 2023 08:13
@vitess-bot vitess-bot bot mentioned this pull request Mar 7, 2023
Merged
frouioui added a commit that referenced this pull request Mar 7, 2023
@vitess-bot @frouioui
[release-16.0] Fix dubious ownership of git directory in `vitess/base…
8cae9d6 
…` Docker build (#12530) (#12561)

* Fix dubious ownership of git directory in vitess/base Docker build

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Use consistent method to copy and build vitess between base and lite

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix all base Dockerfiles

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@arthurschreiber arthurschreiber arthurschreiber approved these changes

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: Build/CI Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: Failing vitess/base docker build due to git error
4 participants
@frouioui @arthurschreiber @deepthi @mattlord