Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-16.0] Examples, Flakes: Wait for Shard's VReplication Engine to Open (#12560) #12581

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Mar 9, 2023

Description

This is a manual backport of #12560.

I should have added the Backport to: release-16.0 label to the PR because it improves the reliability of the tests when run locally by users as well — but I did not do so before it was merged. Thus I'm doing the Bot's job here. 🙂

…sio#12560)

* Examples: wait for shard's vreplication engine to open

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Minor comment changes

Signed-off-by: Matt Lord <mattalord@gmail.com>

---------

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord added the Backport This is a backport label Mar 9, 2023
@vitess-bot vitess-bot bot added the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Mar 9, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 9, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added the NeedsWebsiteDocsUpdate What it says label Mar 9, 2023
@mattlord mattlord marked this pull request as ready for review March 9, 2023 00:30
@mattlord mattlord requested a review from deepthi as a code owner March 9, 2023 00:30
@frouioui frouioui merged commit 824e123 into vitessio:release-16.0 Mar 9, 2023
@frouioui frouioui deleted the backport-v16-12560 branch March 9, 2023 06:58
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants