planner: fix predicate simplifier #12650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui
reviewed
Mar 20, 2023
frouioui
reviewed
Mar 20, 2023
frouioui
reviewed
Mar 20, 2023
frouioui
reviewed
Mar 20, 2023
frouioui
reviewed
Mar 20, 2023
frouioui
reviewed
Mar 20, 2023
frouioui
approved these changes
Mar 20, 2023
harshit-gangal
approved these changes
Mar 20, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Nicer panic message Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Signed-off-by: Andres Taylor <andres@taylor.se>
frouioui
added a commit
to planetscale/vitess
that referenced
this pull request
Mar 28, 2023
* planner: fix predicate simplifier Signed-off-by: Andres Taylor <andres@planetscale.com> * predicate rewriting: add debug logging Signed-off-by: Andres Taylor <andres@planetscale.com> * add debug logging to make the code easier to understand Signed-off-by: Andres Taylor <andres@planetscale.com> * address review feedback Signed-off-by: Andres Taylor <andres@planetscale.com> * Update go/vt/vtgate/planbuilder/predicate_rewrite_test.go Nicer panic message Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Signed-off-by: Andres Taylor <andres@taylor.se> --------- Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@taylor.se> Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
added a commit
that referenced
this pull request
Mar 28, 2023
* planner: fix predicate simplifier * predicate rewriting: add debug logging * add debug logging to make the code easier to understand * address review feedback * Update go/vt/vtgate/planbuilder/predicate_rewrite_test.go Nicer panic message --------- Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@taylor.se> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the predicate rewriting that we added recently, a bug snuck in that can mangle predicates in a bad way.
This PR fixes that, and also introduces fuzz testing that should find any other problems
Related Issue(s)
Fixes #12645
Checklist