Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary code bits in workflows #12756

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Remove unnecessary code bits in workflows #12756

merged 1 commit into from
Mar 30, 2023

Conversation

frouioui
Copy link
Member

Description

As mentioned by @pnacht in #12718 (#12718 (comment)) we still have some unnecessary bits of code in our workflow files, this Pull Request removes those bits.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@frouioui
Remove unnecessary code bits in workflows
07a659a 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 29, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 29, 2023
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Build/CI Backport to: release-14.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 29, 2023
rohit-nayak-ps
rohit-nayak-ps approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frouioui frouioui added this to the v17.0.0 milestone Mar 29, 2023
mattlord
mattlord approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this wasn't in a template.

DON'T FORGET TO REMOVE! ... ... 2 years later... 😄 ❤️

@frouioui
Copy link
Member Author

I'm assuming this wasn't in a template.

@mattlord it was not :-)

@frouioui frouioui merged commit 18e665d into vitessio:main Mar 30, 2023
112 of 114 checks passed
@frouioui frouioui deleted the remove-unnecessary-workflow-bits branch March 30, 2023 06:24
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 30, 2023

I was unable to backport this Pull Request to the following branches: release-14.0, release-15.0, release-16.0.

frouioui added a commit to planetscale/vitess that referenced this pull request Mar 30, 2023
@frouioui
Remove unnecessary code bits in workflows (vitessio#12756)
e6a9c45 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit to planetscale/vitess that referenced this pull request Mar 30, 2023
@frouioui
Remove unnecessary code bits in workflows (vitessio#12756)
de13214 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit to planetscale/vitess that referenced this pull request Mar 30, 2023
@frouioui
Remove unnecessary code bits in workflows (vitessio#12756)
e0280b7 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
This was referenced Mar 30, 2023
Merged
Merged
Merged
frouioui added a commit that referenced this pull request Mar 31, 2023
@frouioui
Remove unnecessary code bits in workflows (#12756) (#12775)
984793f 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Mar 31, 2023
@frouioui
Remove unnecessary code bits in workflows (#12756) (#12774)
e757ea4 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Mar 31, 2023
@frouioui
Remove unnecessary code bits in workflows (#12756) (#12773)
cba9d18 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit to planetscale/vitess that referenced this pull request Nov 21, 2023
@planetscale-actions-bot @frouioui
Remove unnecessary code bits in workflows (vitessio#12756) (vitessio#…
3bab306 
…12775) (vitessio#1776)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlord mattlord mattlord approved these changes

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v17.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frouioui @mattlord @rohit-nayak-ps