Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to golangci-lint and bump its version #12852

Merged
merged 1 commit into from Apr 6, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Apr 6, 2023

Description

This Pull Request bumps the version we use for golangci-lint from 1.51.2 to 1.52.2. We're now using --timeout 10m when calling golangci-lint in our CI workflow. The default timeout is 1 minute can be easily reached without cache.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 6, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 6, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui added Type: Bug Component: Build/CI Flakes Backport to: release-15.0 go and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 6, 2023
@github-actions github-actions bot added this to the v17.0.0 milestone Apr 6, 2023
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frouioui frouioui requested a review from dbussink April 6, 2023 14:25
@dbussink dbussink merged commit c0463e3 into vitessio:main Apr 6, 2023
114 checks passed
@dbussink dbussink deleted the fix-golangci-lint-flakiness branch April 6, 2023 14:27
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 6, 2023

I was unable to backport this Pull Request to the following branches: release-15.0, release-16.0.

frouioui added a commit to planetscale/vitess that referenced this pull request Apr 6, 2023
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit to planetscale/vitess that referenced this pull request Apr 6, 2023
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Apr 11, 2023
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Apr 11, 2023
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit to planetscale/vitess that referenced this pull request Nov 21, 2023
…itessio#1844)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
timvaillancourt pushed a commit to slackhq/vitess that referenced this pull request Mar 15, 2024
…itessio#12853)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Mar 15, 2024
* go1.20.14

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* more go-version: updates

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* make proto w/go1.20

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Fix the golangci-lint config (vitessio#11812)

There's a bunch of deprecated linters that don't work anymore, so let's
remove them:

```
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649.
```

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

* update golangci-lint to 1.50.1 (vitessio#11873)

Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Add timeout to golangci-lint and bump its version (vitessio#12852) (vitessio#12853)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Upgrade `release-16.0` to `go1.20.1` (vitessio#12398)

* Upgrade release-16.0 to go1.19.6

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* upgrade to 1.20.1

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* bump the golangci-lint version

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix TestTLSClientVerifyIdentity

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Switch to using new Go 1.19 CRL parser (vitessio#12315)

`x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList`
instead which is new in Go 1.19.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Skip TestFuzz for now

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

* Remove recent golangci-lint version bump (vitessio#12909)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fix conflict resolution

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* make ensure_bootstrap_version

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* hardcode previous release

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Add comment for hardcoded previous release

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants