Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner fix: scoping rules for JOIN ON expression inside a subquery #12881

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Apr 12, 2023

Description

This PR updates the scoping rules for expressions involved in join table ON clauses, allowing them to use the scope of the SELECT statement's parent scope.

In MySQL 5.7, this scoping rule is not supported. However, MySQL 8.0 and later versions do support this functionality.

For example, consider the following query:

SELECT 1, (SELECT foo FROM t1 JOIN t2 ON t1.col = t2.col AND t1.id = t3.id) subquery FROM t3;

With the updated scoping rules, the join condition between t1 and t2 can now reference columns from t3, essentially allowing access to all columns available from the outer query.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Apr 12, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 12, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 12, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v17.0.0 milestone Apr 12, 2023
Signed-off-by: harshit-gangal <harshit@planetscale.com>
@systay systay changed the title fix: scoping rules for on clause expression inside a subquery planner fix: scoping rules for JOIN ON expression inside a subquery Apr 13, 2023
Signed-off-by: harshit-gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Apr 13, 2023
@harshit-gangal harshit-gangal marked this pull request as ready for review April 13, 2023 12:08
@frouioui frouioui merged commit a5b21bc into vitessio:main Apr 13, 2023
113 of 114 checks passed
@frouioui frouioui deleted the scoper-onclause branch April 13, 2023 22:25
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 13, 2023

I was unable to backport this Pull Request to the following branches: release-14.0, release-15.0, release-16.0.

frouioui pushed a commit to planetscale/vitess that referenced this pull request Apr 13, 2023
…itessio#12881)

* fix: scoping rules for on clause expression inside a subquery

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* find the parent scope of the statement in on clause

Signed-off-by: harshit-gangal <harshit@planetscale.com>

* addressed review comments

Signed-off-by: harshit-gangal <harshit@planetscale.com>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: harshit-gangal <harshit@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui pushed a commit to planetscale/vitess that referenced this pull request Apr 13, 2023
…itessio#12881)

* fix: scoping rules for on clause expression inside a subquery

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* find the parent scope of the statement in on clause

Signed-off-by: harshit-gangal <harshit@planetscale.com>

* addressed review comments

Signed-off-by: harshit-gangal <harshit@planetscale.com>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: harshit-gangal <harshit@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui pushed a commit to planetscale/vitess that referenced this pull request Apr 13, 2023
…itessio#12881)

* fix: scoping rules for on clause expression inside a subquery

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* find the parent scope of the statement in on clause

Signed-off-by: harshit-gangal <harshit@planetscale.com>

* addressed review comments

Signed-off-by: harshit-gangal <harshit@planetscale.com>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: harshit-gangal <harshit@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Apr 14, 2023
…de a subquery (#12891)

* planner fix: scoping rules for JOIN ON expression inside a subquery (#12881)

* fix: scoping rules for on clause expression inside a subquery

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* find the parent scope of the statement in on clause

Signed-off-by: harshit-gangal <harshit@planetscale.com>

* addressed review comments

Signed-off-by: harshit-gangal <harshit@planetscale.com>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: harshit-gangal <harshit@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fix plan test expectation for v3

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: harshit-gangal <harshit@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
frouioui added a commit that referenced this pull request Apr 14, 2023
…12881) (#12889)

* fix: scoping rules for on clause expression inside a subquery



* find the parent scope of the statement in on clause



* addressed review comments



---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: harshit-gangal <harshit@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal added a commit that referenced this pull request Apr 18, 2023
…de a subquery (#12890)

* planner fix: scoping rules for JOIN ON expression inside a subquery (#12881)

* fix: scoping rules for on clause expression inside a subquery

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* find the parent scope of the statement in on clause

Signed-off-by: harshit-gangal <harshit@planetscale.com>

* addressed review comments

Signed-off-by: harshit-gangal <harshit@planetscale.com>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: harshit-gangal <harshit@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fix plan test expectation for v3

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: harshit-gangal <harshit@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal self-assigned this Apr 27, 2023
frouioui pushed a commit to planetscale/vitess that referenced this pull request Nov 21, 2023
…pression inside a subquery (vitessio#1912)

* cherry pick of 12881

* empty-commit to trigger CI

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Bug Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Table name or alias isn't recognized within JOIN of a nested subquery within SELECT clause
3 participants