Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the resilientQuery to give correct results during initialization #13080

Merged

Conversation

GuptaManan100
Copy link
Member

Description

This PR fixes the bug described in #13079. Earlier, in resilientQuery, if we saw that we don't need to refresh the local cache information, we would immediately return the cached value or an error. But, if the cache gets hammered with multiple queries when it starts up, the first query tries to refresh the cache, but the subsequent end up returning the cached result, which doesn't exist! (cache is starting up).

The fix implemented is to first verify that the cache is actually valid or not. If it isn't, then we wait for the previous refresh's output as well.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

…started

Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 12, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented May 12, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v17.0.0 milestone May 12, 2023
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels May 12, 2023
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented May 15, 2023

I was unable to backport this Pull Request to the following branches: release-14.0.

GuptaManan100 added a commit to planetscale/vitess that referenced this pull request May 15, 2023
…itessio#13080)

* feat: fix the resilient query code to work better right after it has started

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: return after erroring out in TimeoutAction

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
frouioui pushed a commit that referenced this pull request May 15, 2023
…initialization (#13080) (#13086)

* feat: fix the resilient query code to work better right after it has started

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: return after erroring out in TimeoutAction

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
frouioui pushed a commit that referenced this pull request May 15, 2023
…initialization (#13080) (#13087)

* feat: fix the resilient query code to work better right after it has started

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: return after erroring out in TimeoutAction

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
harshit-gangal pushed a commit that referenced this pull request May 16, 2023
…13080) (#13088)

* feat: fix the resilient query code to work better right after it has started



* feat: return after erroring out in TimeoutAction



---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: resilientQuery sometimes doesn't return the correct results while initialisation
3 participants