-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the resilientQuery to give correct results during initialization #13080
Merged
GuptaManan100
merged 2 commits into
vitessio:main
from
planetscale:resilient-query-initialization-fix
May 15, 2023
Merged
Fix the resilientQuery to give correct results during initialization #13080
GuptaManan100
merged 2 commits into
vitessio:main
from
planetscale:resilient-query-initialization-fix
May 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…started Signed-off-by: Manan Gupta <manan@planetscale.com>
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
May 12, 2023
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
GuptaManan100
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
May 12, 2023
dbussink
approved these changes
May 12, 2023
Signed-off-by: Manan Gupta <manan@planetscale.com>
frouioui
approved these changes
May 12, 2023
GuptaManan100
added
Backport to: release-14.0
Type: Internal Cleanup
and removed
Type: Internal Cleanup
labels
May 15, 2023
I was unable to backport this Pull Request to the following branches: |
GuptaManan100
added a commit
to planetscale/vitess
that referenced
this pull request
May 15, 2023
…itessio#13080) * feat: fix the resilient query code to work better right after it has started Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: return after erroring out in TimeoutAction Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com>
frouioui
pushed a commit
that referenced
this pull request
May 15, 2023
…initialization (#13080) (#13086) * feat: fix the resilient query code to work better right after it has started Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: return after erroring out in TimeoutAction Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
frouioui
pushed a commit
that referenced
this pull request
May 15, 2023
…initialization (#13080) (#13087) * feat: fix the resilient query code to work better right after it has started Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: return after erroring out in TimeoutAction Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug described in #13079. Earlier, in
resilientQuery
, if we saw that we don't need to refresh the local cache information, we would immediately return the cached value or an error. But, if the cache gets hammered with multiple queries when it starts up, the first query tries to refresh the cache, but the subsequent end up returning the cached result, which doesn't exist! (cache is starting up).The fix implemented is to first verify that the cache is actually valid or not. If it isn't, then we wait for the previous refresh's output as well.
Related Issue(s)
Checklist
Deployment Notes