Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Pass on --keep_routing_rules flag value for Cancel action #13171

Merged
merged 2 commits into from
May 29, 2023

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented May 26, 2023

Description

VReplication vtctl client workflow commands such as MoveTables and Reshard take a --keep_routing_rules flag. This flag's value, however, was NOT passed on to the command execution for the Cancel action. This PR corrects that and adds endtoend testing for it in the existing TestVReplicationDDLHandling test since that does a lot of Cancels.

Manual test:

git checkout main && make build
cd examples/local

./101_initial_cluster.sh; mysql < ../common/insert_commerce_data.sql; ./201_customer_tablets.sh

vtctlclient MoveTables -- --source commerce --tables 'customer,corder' Create customer.commerce2customer
vtctldclient GetRoutingRules

vtctlclient MoveTables -- --source commerce --keep_routing_rules Cancel customer.commerce2customer
vtctldclient GetRoutingRules

./401_teardown.sh

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Signed-off-by: Matt Lord <mattalord@gmail.com>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 26, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented May 26, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v17.0.0 milestone May 26, 2023
@mattlord mattlord removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels May 26, 2023
@mattlord mattlord mentioned this pull request May 26, 2023
42 tasks
@mattlord mattlord marked this pull request as ready for review May 26, 2023 22:11
@mattlord mattlord requested review from deepthi and removed request for notfelineit May 27, 2023 00:32
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord merged commit 6e4005f into vitessio:main May 29, 2023
112 checks passed
@mattlord mattlord deleted the vrepl_cancel_keep_rr branch May 29, 2023 20:46
mattlord added a commit that referenced this pull request May 30, 2023
…for Cancel action (#13171) (#13194)

* Pass on keep_routing_rules flag value for Cancel action

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Add e2e test for Cancel --keep_routing_rules

Signed-off-by: Matt Lord <mattalord@gmail.com>

---------

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bug Report: VReplication workflow's --keep_routing_rules flag does not work with Cancel
4 participants