-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: errant GTID in health streamer #13184
Fix: errant GTID in health streamer #13184
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you've followed the same pattern as replTracker
. I can't say that I like this spreading around of primary/serving state between the various sub-structs of tmState
, but there doesn't seem to be any better way of doing it.
|
Signed-off-by: Manan Gupta <manan@planetscale.com>
The upgrade downgrade failures look unrelated. I will investigate them separately. |
272004c
into
vitessio:release-16.0
I was unable to backport this Pull Request to the following branches: |
@frouioui is taking a look at the upgrade downgrade failures |
* test: add health-streamer test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix health streamer Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix health streamer tests Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com>
* test: add health-streamer test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix health streamer Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix health streamer tests Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com>
Description
This PR fixes the health streamer issue described in #13182. This is a partial back port of #13121
Related Issue(s)
Checklist
Deployment Notes