Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: errant GTID in health streamer #13184

Merged
merged 4 commits into from
May 31, 2023

Conversation

GuptaManan100
Copy link
Member

Description

This PR fixes the health streamer issue described in #13182. This is a partial back port of #13121

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 29, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented May 29, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v16.0.3 milestone May 29, 2023
@GuptaManan100 GuptaManan100 added Type: Bug Component: Query Serving Backport to: release-14.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels May 29, 2023
@GuptaManan100 GuptaManan100 changed the title Fix hs errant Fix: errant GTId in health streamer May 29, 2023
@GuptaManan100 GuptaManan100 changed the title Fix: errant GTId in health streamer Fix: errant GTID in health streamer May 29, 2023
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you've followed the same pattern as replTracker. I can't say that I like this spreading around of primary/serving state between the various sub-structs of tmState, but there doesn't seem to be any better way of doing it.

@deepthi
Copy link
Member

deepthi commented May 29, 2023

unit_race is actually failing. It's a good thing we run our unit tests with the race detector 😅

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
Copy link
Member Author

The upgrade downgrade failures look unrelated. I will investigate them separately.

@GuptaManan100 GuptaManan100 merged commit 272004c into vitessio:release-16.0 May 31, 2023
110 of 112 checks passed
@GuptaManan100 GuptaManan100 deleted the fix-hs-errant branch May 31, 2023 11:22
@vitess-bot
Copy link
Contributor

vitess-bot bot commented May 31, 2023

I was unable to backport this Pull Request to the following branches: release-14.0, release-15.0.

@GuptaManan100
Copy link
Member Author

GuptaManan100 commented Jun 1, 2023

@frouioui is taking a look at the upgrade downgrade failures

GuptaManan100 added a commit to planetscale/vitess that referenced this pull request Jun 5, 2023
* test: add health-streamer test

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix test

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix health streamer

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix health streamer tests

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100 added a commit to planetscale/vitess that referenced this pull request Jun 5, 2023
* test: add health-streamer test

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix test

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix health streamer

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix health streamer tests

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100 added a commit that referenced this pull request Jun 6, 2023
* test: add health-streamer test



* feat: fix test



* feat: fix health streamer



* feat: fix health streamer tests



---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100 added a commit that referenced this pull request Jun 6, 2023
* test: add health-streamer test



* feat: fix test



* feat: fix health streamer



* feat: fix health streamer tests



---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants