Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add group_concat aggregation support #13331

Merged
merged 9 commits into from
Jun 22, 2023
Merged

Add group_concat aggregation support #13331

merged 9 commits into from
Jun 22, 2023

Commits on Jun 20, 2023

  1. addeed group_concat engine support 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4a042a6 View commit details
    Browse the repository at this point in the history

  2. added scalar support 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    e06f12b View commit details
    Browse the repository at this point in the history

  3. added planning support 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    3836152 View commit details
    Browse the repository at this point in the history

  4. refactor planOffsetsNotPushed method with better handling of errors 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ccb75a5 View commit details
    Browse the repository at this point in the history

  5. added planning support for group_concat 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    08285da View commit details
    Browse the repository at this point in the history

  6. group_concat aggregation to return type based on the field type 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    a484985 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. push weight_string columns for aggregator grouping and aggregation wh… 

    …en they are not pushed down while planning

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    12f51e8 View commit details
    Browse the repository at this point in the history

  2. test: added e2e test for group_concat 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    28f378d View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. small refactor 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    6e6ce2e View commit details
    Browse the repository at this point in the history