Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Expression and Statement Simplifier #13636

Merged
merged 17 commits into from
Aug 9, 2023
Merged

Refactor Expression and Statement Simplifier #13636

merged 17 commits into from
Aug 9, 2023

Commits on Aug 1, 2023

  1. copied changes to the simplifier from PR vitessio#13460 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b12911a View commit details
    Browse the repository at this point in the history

  2. refactored depth to GetDepth and to use SafeRewrite 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    23a8421 View commit details
    Browse the repository at this point in the history

  3. refactor expression simplifier except for root simplification 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ae0ffec View commit details
    Browse the repository at this point in the history

  4. expression simplifier can now rewrite top node 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    e42d9f7 View commit details
    Browse the repository at this point in the history

  5. refactor trySimplifyUnions to use SafeRewrite 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a859361 View commit details
    Browse the repository at this point in the history

  6. bugfix: simplifier would not properly simplify unnecessary tables 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c4dc8ab View commit details
    Browse the repository at this point in the history

  7. convert removeTable switch cases to functions 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    75b03fc View commit details
    Browse the repository at this point in the history

  8. use keepSameError in removeTableinWhere 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    f9a5125 View commit details
    Browse the repository at this point in the history

  9. refact simplifyStarExpr to use SafeRewrite 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ad3dbcd View commit details
    Browse the repository at this point in the history

  10. replaced Rewrite with SafeRewrite in visitAllExpressionsInAST 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c378d5e View commit details
    Browse the repository at this point in the history

  11. bugfix: table columns can only be removed after the table has been re… 

    …moved

Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    60a593d View commit details
    Browse the repository at this point in the history

  12. refactor visitAllExpressionsInAST 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    f9ce085 View commit details
    Browse the repository at this point in the history

  13. added distinct simplification 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c135a9f View commit details
    Browse the repository at this point in the history

  14. added distinct simplification to aggregation expressions 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    aae64af View commit details
    Browse the repository at this point in the history

  15. added capability for simplifier to remove a limit clause 

    Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    5be4bc8 View commit details
    Browse the repository at this point in the history

  16. changed expressions simplifier to keep rewriting until there are no c… 

    …hanges

Signed-off-by: Arvind Murty <10248018+arvind-murty@users.noreply.github.com>
    @arvind-murty
    arvind-murty committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    06168dc View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Merge branch 'main' into am-refactor-simplifier

    @systay
    systay committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    182f367 View commit details
    Browse the repository at this point in the history