Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16 backport: Fix closed channel panic in Online DDL cutover #13732

Merged

Conversation

shlomi-noach
Copy link
Contributor

Manual backport of #13729

For some reason the backport bot did not run.

This backport is not strictly required, since the bug does not happen in v16 - the channel wasn't being closed in this version. However, we do the backport so as to close the channel appropriately and release resources.

Description

Closing a channel should be owned by the writer to the channel. This PR fixes a closed channel panic, described in #13728.

Related discussion in golang google group: https://groups.google.com/g/golang-nuts/c/_Q6FCjWIr18/m/Wb_NlyusRL8J?pli=1

Related Issue(s)

#13728

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach added Type: Bug Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Aug 7, 2023
@shlomi-noach shlomi-noach requested a review from a team August 7, 2023 06:00
@github-actions github-actions bot added this to the v16.0.4 milestone Aug 7, 2023
@shlomi-noach shlomi-noach added the Backport This is a backport label Aug 7, 2023
@rohit-nayak-ps rohit-nayak-ps merged commit 4a810e4 into vitessio:release-16.0 Aug 8, 2023
113 of 114 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the fix-close-rename-chan-v16 branch August 8, 2023 07:14
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport This is a backport Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants