v17 backport: Solve RevertMigration.Comment read/write concurrency issue #13734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…13700) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
added
Type: Bug
Backport
shlomi-noach
requested review from
mattlord,
rohit-nayak-ps,
harshit-gangal,
systay and
GuptaManan100
as code owners
frouioui
approved these changes
Aug 7, 2023
rohit-nayak-ps
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #13700
Description
In this PR we clone the
RevertMigration.Commentsmap before iterating it. Thus, we solve an issue of concurrently reading/writing to sameCommentsmap. See #13699 for details.To be backported to all supported versions.
Related Issue(s)
Fixes #13699
Checklist
Deployment Notes