Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtexplain: Fix setting up the column information #15275

Merged
merged 3 commits into from
Feb 19, 2024

Commits on Feb 17, 2024

  1. vtexplain: Fix setting up the column information

    In vitessio#13312 we fixed how we encode
    names in information_schema queries. The problem there though is that
    the `GetColumnNamesQuery` string was also used inside `vtexplain`. It's
    usage there was not updated for the new escaping logic.
    
    This in turn leads to broken queries during `vtexplain` which then leads
    to a lot of logs. The issue here is not that we log a lot, we log that
    we actually do have a problem here which is the case.
    
    This fixes the underlying issue of not correctly generating the query as
    we should.
    
    Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
    dbussink committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    939de97 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. Add basic test

    Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
    dbussink committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    241d5f5 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Remove unneeded duplicate function

    There's already `sqltypes.EncodeStringSQL` which implements the exact
    same thing.
    
    Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
    dbussink committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    4f04f20 View commit details
    Browse the repository at this point in the history