Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codebeat badge #1568

Merged
merged 3 commits into from
Mar 21, 2016
Merged

codebeat badge #1568

merged 3 commits into from
Mar 21, 2016

Conversation

korzonek
Copy link
Contributor

Is it fine to add codebeat badge to README?

codebeat is automated code review tool for Swift,Ruby,Go & Python that helps get instant feedback on code quality.

"Quick wins" suggested by codebeat could be a nice candidate for a pull request and help other developers become contributors.

FYI. To be fully open and honest. I'm co-founder of codebeat.


This change is Reviewable

Is it fine to add codebeat badge to README? 

codebeat is automated code review tool for Swift,Ruby,Go & Python that helps get instant feedback on code quality. 

"Quick wins" suggested by codebeat could be a nice candidate for a pull request and help other developers become contributors.

FYI. To be fully open and honest. I'm co-founder of codebeat.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@enisoc
Copy link
Member

enisoc commented Mar 16, 2016

Looks interesting. I don't see any harm in trying it out. Can you add a space after the Travis badge, and accept the CLA?

@enisoc enisoc self-assigned this Mar 17, 2016
@googlebot
Copy link

CLAs look good, thanks!

I had some issue with alignment of the badge. Is it fine if all badges are aligned to left. Does it work for you?
@korzonek
Copy link
Contributor Author

I had some issue with alignment of the badge. Is it fine if all badges are aligned to left. Does it work for you?

@enisoc
Copy link
Member

enisoc commented Mar 21, 2016

LGTM

Approved with PullApprove

enisoc added a commit that referenced this pull request Mar 21, 2016
@enisoc enisoc merged commit cd63133 into vitessio:master Mar 21, 2016
systay pushed a commit to planetscale/vitess that referenced this pull request Mar 7, 2023
…ssio#1568)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants