tabletmanager: Add integration test for immediate health broadcast after state changes. #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM other than comment above. |
…rned by SetServingType().
…oadcast message knowingly. Since my change in commit cdf9478 we broadcast more health messages now. Before this change, healthcheck_test.go would just ignore the extra messages. Now, it's part of the test which health broadcast message with which data we expect at each point in time. I've also added support for verifying all state changes since I found an issue where the QueryService is running although TabletControl disables it.
…mediately when the QueryService state changes. Note: The code for the immediate health messages was introduced in commit cdf9478.
In case of the special cases mentioned in the comment, we also enter the lameduck mode. See the code in state_change.go for what is actually implemented.
michael-berlin
force-pushed
the
healthcheck_unit_test
branch
from
839fe0f
to
1030ecf
Compare
|
I've addressed your comment and removed the comment in the code. |
michael-berlin
added a commit
that referenced
this pull request
Mar 16, 2016
tabletmanager: Add integration test for immediate health broadcast after state changes.
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 7, 2023
* fix: aggregation coming from right hand side of left join check for null * test: added a sum test * addressed review comments --------- Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alainjobart @enisoc
This adss a test for the change in #1551.
I've also refactored the test in general and made it more "tight": It has to consume each health broadcast message now and mustn't leave out any.
This change is