Adding keyspace to go client API.

[alainjobart]

It's a per connection parameter, so we don't have to send it in every
Execute() or StreamExecute() call.

@enisoc go version of the change.

---

This change is

[enisoc]

Reviewed 12 of 12 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

go/cmd/vtgateclienttest/goclienttest/main.go, line 27 [r1] (raw file):

  // Create a client connecting to the server
  ctx := context.Background()
  conn, err := vtgateconn.DialProtocol(ctx, protocol, addr, 30*time.Second, "conn_ks")

Need to add assertion of keyspace value for Execute(), StreamExecute(), and tx.Execute() in echo.go.

---

go/vt/vtctl/query.go, line 50 [r1] (raw file):

          "VtGateExecute",
          commandVtGateExecute,
          "-server <vtgate> [-bind_variables <JSON map>] [-connect_timeout <connect timeout>] [-tablet_type <tablet type>] [-json] <sql>",

Add [-keyspace <default keyspace>].

Also regenerate vtctl reference doc.

---

Comments from Reviewable

[alainjobart]

Review status: 10 of 14 files reviewed at latest revision, 2 unresolved discussions.

---

go/cmd/vtgateclienttest/goclienttest/main.go, line 27 [r1] (raw file):

Previously, enisoc (Anthony Yeh) wrote…

Need to add assertion of keyspace value for Execute(), StreamExecute(), and tx.Execute() in echo.go.

Done.

---

go/vt/vtctl/query.go, line 50 [r1] (raw file):

Previously, enisoc (Anthony Yeh) wrote…

Add [-keyspace <default keyspace>].

Also regenerate vtctl reference doc.

Done.

---

Comments from Reviewable

[enisoc]

Previously, alainjobart (Alain Jobart) wrote…

Adding keyspace to go client API.

It's a per connection parameter, so we don't have to send it in every

Execute() or StreamExecute() call.

@enisoc go version of the change.

---

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable