schemamanager: Change PreflightSchemaChange to accept a list of changes instead of a single change. #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ious SQL statements within the same ApplySchema command are not considered. For example, ApplySchema could DROP and then CREATE a table. Since the DROP is not considered during preflight, CREATE will fail with the error that the table already exists.
…es instead of a single change. This makes it easier to test multiple changes which depend on each other e.g. a CREATE TABLE after a DROP TABLE if the table already exists. Fixes issue vitessio#1731 (comment).
michael-berlin
force-pushed
the
schema_fix
branch
from
4a638b8
to
129772b
Compare
|
LGTM |
michael-berlin
force-pushed
the
schema_fix
branch
from
6f5af88
to
c2db676
Compare
This simplifies executing the new PreflightSchema and passing on its response.
michael-berlin
force-pushed
the
schema_fix
branch
from
c2db676
to
3e822ee
Compare
|
@alainjobart Please have a look at the last commit. I've moved the message into the proto. This made the new PreflightSchema RPC simpler. |
|
LGTM good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to test multiple changes which depend on each other e.g. a CREATE TABLE after a DROP TABLE if the table already exists.
Fixes issue #1731 (comment).
@alainjobart
This change is