Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support USE statements, which may optionally have quoted identifiers #2719

Closed
wants to merge 1 commit into from

Conversation

bbeaudreault
Copy link
Contributor

@alainjobart was having trouble finding tests for this particular area

@bbeaudreault bbeaudreault force-pushed the mysql_support_use branch 2 times, most recently from aef91b1 to 22d6fec Compare March 30, 2017 17:46
@bbeaudreault
Copy link
Contributor Author

bbeaudreault commented Apr 14, 2017

@sougou thoughts on this? i don't think it's superseded by #2751

@sougou
Copy link
Contributor

sougou commented Apr 14, 2017

Forgot to mention. #2751 will be followed by a more universal implementation of USE that will make this obsolete, which is why I haven't approved this.
We were waiting for 2.1 to be cut. So, now I can submit that after @michael-berlin approves, and work on the subsequent PRs. :)

@bbeaudreault
Copy link
Contributor Author

Ok sounds good, thanks. If that's the case I'm going to hijack this PR for the travis testing and add my unapproved code snippet from #2677 for inverting the single-db /0 logic. It will make it easier on my developers who are using the mysql prompt while we wait for the followup PRs.

@bbeaudreault
Copy link
Contributor Author

bbeaudreault commented May 29, 2017

@sougou where did we land with:

Forgot to mention. #2751 will be followed by a more universal implementation of USE that will make this obsolete, which is why I haven't approved this.

I know you added USE support, but do we still have cases where doing USE foo/0 results in more query flexibility than USE foo?

This branch is a pain to keep up-to-date as I pull in upstream changes. But we're starting to roll out vitess to more people now and I don't want them all to have to start remembering to always add a /0 when running ad hoc queries with the mysql server plugin

@sougou
Copy link
Contributor

sougou commented May 29, 2017

For all practical purposes. foo and foo/0 should work the same. There may be some exotic corner cases where it may not work. So, this can be closed.

@bbeaudreault
Copy link
Contributor Author

Ok I'll close this for now and enter a separate issue if we run into issues. Thanks

frouioui pushed a commit to planetscale/vitess that referenced this pull request Nov 21, 2023
…n: Ensure ROW events are sent within a transaction (vitessio#2736)

* backport of 2719

* Fix conflicts

Signed-off-by: Matt Lord <mattalord@gmail.com>

---------

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>
frouioui pushed a commit to planetscale/vitess that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants