Fix connection leak in vtworker #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Pawliszyn <mikepaw@squareup.com>
systay
approved these changes
Feb 4, 2019
Signed-off-by: Andres Taylor <antaylor@squareup.com>
Signed-off-by: Andres Taylor <antaylor@squareup.com>
sougou
approved these changes
Feb 4, 2019
|
I know Sugu has already merged this PR, but can you take a look at my
comment?
#4585 (comment)
…On Mon, Feb 4, 2019 at 3:27 PM Sugu Sougoumarane ***@***.***> wrote:
Merged #4585 <#4585> into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4585 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAXs14bXgwp5Xy6DqjWsNTnhqVaxYt9Eks5vKMHGgaJpZM4aei0E>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work was mostly done by @eeSeeGee . I just had to rebase it a bit.
Without this after using the worker for a while the machine can run out of ports to hand out.
Signed-off-by: Michael Pawliszyn mikepaw@squareup.com