Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bool as column type #4609

Merged
merged 1 commit into from Feb 12, 2019
Merged

Support bool as column type #4609

merged 1 commit into from Feb 12, 2019

Conversation

kuba--
Copy link
Collaborator

@kuba-- kuba-- commented Feb 11, 2019

Signed-off-by: kuba-- kuba@sourced.tech

This PR adds support for bool, boolean types for column.
It will satisfies queries like:

CREATE TABLE t (b1 boolean not null, b2 bool)

Based on mysql documentation, BOOL type is synonymous for TINYINT.

Support bool as column type
3d8b489 
Signed-off-by: kuba-- <kuba@sourced.tech>
@kuba-- kuba-- requested a review from sougou as a code owner February 11, 2019 15:56
@kuba-- kuba-- mentioned this pull request Feb 11, 2019
Closed
@sougou sougou merged commit 613bb78 into vitessio:master Feb 12, 2019
@kuba-- kuba-- deleted the bool-type branch February 12, 2019 08:15
@zmagg zmagg mentioned this pull request Mar 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuba-- @sougou