Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct the error parameter in the local example script #4770

Merged
merged 1 commit into from Apr 2, 2019
Merged

correct the error parameter in the local example script #4770

merged 1 commit into from Apr 2, 2019

Conversation

dcadevil
Copy link
Contributor

@dcadevil dcadevil commented Apr 1, 2019 •
edited

The parameter min_healthy_rdonly_tablets in the example script should be changed to min_healthy_tablets.

Signed-off-by: dcadevil dcadevil@126.com

@dcadevil
correct the error parameter in the local example script
9b79c76 
Signed-off-by: dcadevil <dcadevil@126.com>
@dcadevil dcadevil requested a review from sougou as a code owner April 1, 2019 08:01
deepthi
deepthi reviewed Apr 1, 2019
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What problem is this PR trying to fix? It is not obvious.

@sougou
Copy link
Contributor

sougou commented Apr 1, 2019

Looks like this is related to #4759.
@systay : Looks like more things need to be changed: https://github.com/vitessio/vitess/search?p=2&q=min_healthy_rdonly_tablets&unscoped_q=min_healthy_rdonly_tablets
@rafael: heads up on possible UI breakage.

@systay
Copy link
Collaborator

systay commented Apr 2, 2019

@dcadevil thanks for catching and fixing this

@deepthi deepthi merged commit 35c8588 into vitessio:master Apr 2, 2019
@rafael rafael mentioned this pull request Apr 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dcadevil @sougou @systay @deepthi