Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect ZK_JAVA_OPTS env in zksrv.sh #4784

Merged
merged 1 commit into from Apr 12, 2019
Merged

Conversation

adsr
Copy link
Collaborator

@adsr adsr commented Apr 3, 2019

In our case we'd like to start ZK with -Dzookeeper.DigestAuthenticationProvider.superDigest=.... This might also be generally useful for setting JVM opts.

@adsr adsr requested a review from sougou as a code owner April 3, 2019 20:23
Signed-off-by: Adam Saponara <as@php.net>
Copy link
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit 4d3d859 into vitessio:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants