Add proxy protocol support for vtgate. #5563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test-breakage was due to a GitHub actions issue, which has now been fixed. I just had to restart the test, and it got passed the 'get dependencies' step. |
|
@aquarapid It looks like legit failures in the unit test. Can you take a look? |
morgo
approved these changes
Dec 19, 2019
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
force-pushed
the
jacques_proxy_protocol
branch
from
0f68c6b
to
ca800b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #5554 . Still thinking of how to automate testing for this, but I have confirmed functionality by using haproxy as the proxy sending the PROXY protocol headers.
Use --proxy_protocol flag to vtgate to activate. Default is old (no proxy support) behavior.
Signed-off-by: Jacques Grove aquarapid@gmail.com