Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepared statement testcases #5670

Merged
merged 5 commits into from Jan 19, 2020
Merged

prepared statement testcases #5670

merged 5 commits into from Jan 19, 2020

Conversation

princeparmar
Copy link
Contributor

@princeparmar princeparmar commented Jan 8, 2020 •
edited by deepthi

verifies insert,update,delete and select for prepared statements.
Fixes #5524

Signed-off-by: pradip parmar prince.soamedia@gmail.com

deepthi
deepthi reviewed Jan 13, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits and changes to doc comments.
I'm assuming this covers all cases from the original python test.

go/test/endtoend/prepare-statement/main_test.go Outdated Show resolved Hide resolved
go/test/endtoend/prepare-statement/main_test.go Outdated Show resolved Hide resolved
go/test/endtoend/prepare-statement/main_test.go Outdated Show resolved Hide resolved
go/test/endtoend/prepare-statement/main_test.go Outdated Show resolved Hide resolved
go/test/endtoend/prepare-statement/main_test.go Outdated Show resolved Hide resolved
go/test/endtoend/prepare-statement/stmt_methods_test.go Outdated Show resolved Hide resolved
go/test/endtoend/prepare-statement/stmt_methods_test.go Outdated Show resolved Hide resolved
go/test/endtoend/prepare-statement/stmt_methods_test.go Outdated Show resolved Hide resolved
go/test/endtoend/prepare-statement/stmt_methods_test.go Outdated Show resolved Hide resolved
test/config.json Outdated Show resolved Hide resolved
@deepthi
Copy link
Member

deepthi commented Jan 15, 2020

You will need to resolve the DCO and merge conflict.
Please get @ajeetj or @arindamnayak to help if needed.

@princeparmar
prepare statment test case.
3ab33f6 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar princeparmar reopened this Jan 16, 2020
@deepthi
Copy link
Member

deepthi commented Jan 17, 2020 •
edited

sorry, merging your other PR created conflicts in this one. Can you resolve them?

deepthi
deepthi approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@princeparmar princeparmar reopened this Jan 17, 2020
@princeparmar
prepare_statement: dummy commit.
5c05f6e 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@sougou sougou merged commit 7fe2822 into vitessio:master Jan 19, 2020
@princeparmar princeparmar deleted the prepared-statement branch January 20, 2020 06:20
@ajm188 ajm188 mentioned this pull request Mar 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepared_statement test triggers segfault
3 participants
@princeparmar @deepthi @sougou