consultopo: Enforce a connection heartbeat for Watch(). #5673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've gotten reports from Vitess users who use the consultopo plugin that watches sometimes remain stalled following a network partition, even after the process regains contact with the topo server. This change should help us detect when a consultopo watch connection has silently died while waiting for a long poll response. I haven't thought of a good way to test this since this kind of zombie TCP connection should only happen if even the "connection closed" signal cannot be delivered (like in a network partition, as opposed to a process crash). Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
|
Cool! Thanks @enisoc. I'll keep an eye, see if this covers all the cases we have been running into it to. |
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Mar 11, 2020
We've gotten reports from Vitess users who use the consultopo plugin that watches sometimes remain stalled following a network partition, even after the process regains contact with the topo server. This change should help us detect when a consultopo watch connection has silently died while waiting for a long poll response. I haven't thought of a good way to test this since this kind of zombie TCP connection should only happen if even the "connection closed" signal cannot be delivered (like in a network partition, as opposed to a process crash). Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've gotten reports from Vitess users who use the consultopo plugin that watches sometimes remain stalled following a network partition, even after the process regains contact with the topo server.
This change should help us detect when a consultopo watch connection has silently died while waiting for a long poll response. I haven't thought of a good way to test this since this kind of zombie TCP connection should only happen if even the "connection closed" signal cannot be delivered (like in a network partition, as opposed to a process crash).
cc @rafael