Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-cell tablet picker #6442

Merged
merged 9 commits into from
Jul 17, 2020
Merged

Multi-cell tablet picker #6442

merged 9 commits into from
Jul 17, 2020

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Jul 14, 2020 •
edited
Loading

Currently vreplication uses a healthcheck-based tablet picker that is limited to one cell. This PR changes that to a simpler topology-based tablet_picker that can work cross-cell or via cell aliases.
The list of cells / aliases is provided to tablet picker when it is created.

@deepthi
failing unit test for multi cell
e00a6f6 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
implement multi cell tablet picker
b0e1c8c 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
tablet_picker: now works with cell aliases
4361c56 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
tablet_picker: must respect provided tablet_types
88a7cbf 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
tablet_picker: unit tests
5abf764 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
vreplication multi-cell endtoend test
1e459fd 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
vreplication cell-alias endtoend test
b9a4ea6 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi marked this pull request as ready for review July 16, 2020 01:04
@deepthi deepthi requested a review from sougou as a code owner July 16, 2020 01:04
@deepthi
tablet_picker: special handling for master
166607d 
Signed-off-by: deepthi <deepthi@planetscale.com>
rohit-nayak-ps
rohit-nayak-ps approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go/vt/discovery/tablet_picker.go Outdated Show resolved Hide resolved
@deepthi deepthi requested a review from zmagg July 16, 2020 19:30
sougou
sougou approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge after fix suggested by @rohit-nayak-ps

@deepthi
use existing func, add more unit tests to cover all errors
2d9c8e3 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi merged commit f3066ec into vitessio:master Jul 17, 2020
@deepthi
Copy link
Member Author

deepthi commented Jul 17, 2020

All feedback was addressed before merging.

@deepthi deepthi deleted the ds-tablet-picker-multicell branch July 17, 2020 18:27
@deepthi deepthi added this to the v7.0 milestone Jul 17, 2020
@deepthi
Copy link
Member Author

deepthi commented Jul 21, 2020

Should fix #6366, requires re-testing.

@deepthi deepthi mentioned this pull request Jul 28, 2020
Closed
@rafael rafael mentioned this pull request Aug 5, 2020
Merged
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
@falun falun mentioned this pull request Oct 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@zmagg zmagg Awaiting requested review from zmagg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deepthi @sougou @rohit-nayak-ps