Close reserved connections when client hangs up #6451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a client to the Vite MySQL service port is closed, we used to just need to rollback and open transactions. Now we need to also remember to close any reserved connections. Signed-off-by: Andres Taylor <andres@planetscale.com>
|
I will move this to draft as there is end to end test failing after this change. So, we would need to look it up and fix it. |
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client to the Vitess MySQL service port is closed, we used
to just need to rollback and open transactions. Now we need to also
remember to close any reserved connections.