Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heartbeat: lag histogram #6634

Merged
merged 2 commits into from Sep 9, 2020
Merged

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Aug 26, 2020

Fixes #6528
Sample output from /debug/vars:

"HeartbeatLagNsHistogram": {"0": 0, "1ms": 0, "10ms": 0, "100ms": 16, "1s": 58, "10s": 3, "100s": 0, "1000s": 0, ">1000s": 0, "Count": 77, "Total": 21665771418},

Signed-off-by: deepthi deepthi@planetscale.com

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from sougou as a code owner August 26, 2020 22:58
@deepthi deepthi requested a review from pH14 August 26, 2020 23:00
@deepthi deepthi marked this pull request as draft August 27, 2020 00:17
@deepthi deepthi marked this pull request as ready for review August 27, 2020 00:44
Signed-off-by: deepthi <deepthi@planetscale.com>
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow. can't believe we've lived this long with this bug.

@sougou sougou merged commit 6a25895 into vitessio:master Sep 9, 2020
@deepthi deepthi deleted the ds-lag-histogram branch September 9, 2020 23:48
@askdba askdba added this to the v8.0 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vitess Heartbeats: Additional metrics/stats
3 participants