Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore: checkNoDB should not require tables to be present #6695

Merged
merged 3 commits into from Sep 12, 2020

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Sep 10, 2020

When the desired database is present, we should not check for the existence of tables.
The presence of the database is sufficient to tell us that the instance has been initialized and hence should not be restored from backup.

Signed-off-by: deepthi deepthi@planetscale.com

…esired database is present

Signed-off-by: deepthi <deepthi@planetscale.com>
Copy link
Member

@enisoc enisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: deepthi <deepthi@planetscale.com>
…est, print

command output on failure

Signed-off-by: deepthi <deepthi@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants